From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC0F7C433EF for ; Thu, 12 May 2022 10:30:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352641AbiELKad (ORCPT ); Thu, 12 May 2022 06:30:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352623AbiELKaZ (ORCPT ); Thu, 12 May 2022 06:30:25 -0400 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CC24223840 for ; Thu, 12 May 2022 03:30:23 -0700 (PDT) Received: by mail-ed1-x52e.google.com with SMTP id s11so1884031edy.6 for ; Thu, 12 May 2022 03:30:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Jl+ZZLPEmKFGVogvW81THWaOFnfrMcq7xgsxNJKbp8Y=; b=GzHOlN0ZzVY4PrqYpKqPssLC3MnbSsdquS7slbkn7dcdXDOrQpCRO8USwHNEsG3Ysf jju6K0tEIHtYxB4vhKQcLCXTFcb2Y9juE/nPZnI9LSD+xuSwFndkivKRNQ+dZA+wYnyD oYxi6rdcJ3ZBUG08tLjCMUb3wUfGdt1yHBdL754NRw1j1CoCHU1rkKgEl8haN/BCf0k3 qzmFdXoKxi+jkWpLJSnhloCSptQ+ruWOvyhvxxsimbDX+8Xl6g9xn3e8ZsaYaKvdCClH w8qbLG6rSSGpdpTFjHHKAV3ZKzzLMCLF4hWyUZVEL5r/gyg+vxdCkctA67GXkCCWANDg 8ulA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Jl+ZZLPEmKFGVogvW81THWaOFnfrMcq7xgsxNJKbp8Y=; b=TcezCYQGWRxhtLfVCHhawZPgWyWcvN4u80uaLgWmvDUOB43ltDTTe7e4BX2fekpp+W nANgqjis2aB+a+GNb51vpFzI0nnbdkVP2qKEGRAdU8ODJtoYW3QUY5CqxadgZlf7e1X+ Jn3B59eZE4tD28MZNwDaDPbZwNs95p6I27v9ySVBnA6DQ1BwI4PGKHgfsRcOdPP6TVko 1eMFTqVtYxkKjApVopZFpbs/D3u/0zR159HgiM8F2fntURt98yHiw35XwJ79s8yOhWBl 4qez+w13SZIeXBXkXtHXoosaifyguf2N1cbAPrj2Iq7ULYf563/CanDH7zKVxMW34MIN 3/rQ== X-Gm-Message-State: AOAM533reTMEOfAjltoR1uJn9Kq8u7se54+YfSOsDJaKRpCRWx2SO0lN ex7fUECOP7eCt+UZp52B0hhZng== X-Google-Smtp-Source: ABdhPJyfG2D7eWQvDaS2cd6jcMEovgXAcO4kNIJd+zFA4btjO+0kmpY2e/uHtr9ENXd4dF29PFCiUA== X-Received: by 2002:a05:6402:948:b0:425:ea37:96b8 with SMTP id h8-20020a056402094800b00425ea3796b8mr34018713edz.90.1652351421995; Thu, 12 May 2022 03:30:21 -0700 (PDT) Received: from [192.168.0.158] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q20-20020a170906941400b006f3ef214dd1sm1991452ejx.55.2022.05.12.03.30.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 May 2022 03:30:21 -0700 (PDT) Message-ID: <5b32cecf-873a-6367-df87-1b8d45e63cec@linaro.org> Date: Thu, 12 May 2022 12:30:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [v4 1/3] dt-bindings: phy: qcom,usb-snps-femto-v2: Add phy override params bindings Content-Language: en-US To: Krishna Kurapati PSSNV , Krzysztof Kozlowski , Rob Herring , Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , Wesley Cheng , Vinod Koul Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com, quic_vpulyala@quicinc.com, Sandeep Maheswaram References: <1652282793-5580-1-git-send-email-quic_kriskura@quicinc.com> <1652282793-5580-2-git-send-email-quic_kriskura@quicinc.com> <9644d608-4ab9-ed0d-50fb-0016e4331361@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <9644d608-4ab9-ed0d-50fb-0016e4331361@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/05/2022 07:57, Krishna Kurapati PSSNV wrote: > > On 5/11/2022 11:49 PM, Krzysztof Kozlowski wrote: >> On 11/05/2022 17:26, Krishna Kurapati wrote: >>> From: Sandeep Maheswaram >>> >>> Add device tree bindings for SNPS phy tuning parameters. >>> >>> Signed-off-by: Sandeep Maheswaram >>> Signed-off-by: Krishna Kurapati >>> --- >>> .../bindings/phy/qcom,usb-snps-femto-v2.yaml | 87 ++++++++++++++++++++++ >>> 1 file changed, 87 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml >>> index 1ce251d..70efffe 100644 >>> --- a/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml >>> +++ b/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml >>> @@ -53,6 +53,93 @@ properties: >>> vdda33-supply: >>> description: phandle to the regulator 3.3V supply node. >>> >>> + qcom,hs-disconnect-bps: >>> + $ref: /schemas/types.yaml#/definitions/int32 >>> + description: >>> + This adjusts the voltage level for the threshold used to >>> + detect a disconnect event at the host. Possible values are. >>> + The values defined are in multiples of basis points (1bp = 0.01%). >> This means there is some minimum and maximum (100%)? > > Hi Krzystof, > > Yes there are max and min for each parameter (not necessarily 0%/100%) > > As an example if we take squelch detector threshold, the register value > vs actual percentage changer as per data book is as follows : > > % change in voltage    |     corresponding reg value > >  -20.90%                        |    7 >  -15.60%                        |    6 > -10.30%                         |    5 > -5.30%                           |    4 > 0%                                  |    3 > 5.30%                            |    2 > 10.60%                          |    1 > 15.90%                          |    0 > > Here the min and max are 15.9% to -20.9% > > The min and max differ for each parameter and might not be necessarily > 0% and 100% Then it seems possible to define minimum and maximum values - please add them ("minimum: xxxx"). Best regards, Krzysztof