From: Stefan Agner <stefan@agner.ch>
To: linux@armlinux.org.uk
Cc: arnd@arndb.de, linus.walleij@linaro.org,
akpm@linux-foundation.org, nsekhar@ti.com,
mchehab+samsung@kernel.org, bgolaszewski@baylibre.com,
armlinux@m.disordat.com, benjamin.gaignard@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Michal Hocko <mhocko@suse.com>,
Stefan Agner <stefan@agner.ch>
Subject: [PATCH] arm: make kexec depend on MMU
Date: Wed, 5 Feb 2020 23:43:44 +0100 [thread overview]
Message-ID: <5b595d37283f043df78259221f2b7d18e0cb0ce5.1580942558.git.stefan@agner.ch> (raw)
From: Michal Hocko <mhocko@suse.com>
arm nommu config with KEXEC enabled doesn't compile
arch/arm/kernel/setup.c: In function 'reserve_crashkernel':
arch/arm/kernel/setup.c:1005:25: error: 'SECTION_SIZE' undeclared (first
use in this function)
crash_size, SECTION_SIZE);
since 61603016e212 ("ARM: kexec: fix crashkernel= handling") which is
over one year without anybody noticing. I have only noticed beause of
my testing nommu config which somehow gained CONFIG_KEXEC without
an intention. This suggests that nobody is actually using KEXEC
on nommu ARM configs. It is even a question whether kexec works with
nommu.
Make KEXEC depend on MMU to make this clear. If somebody wants to enable
there will be probably more things to take care.
Signed-off-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: Stefan Agner <stefan@agner.ch>
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
arch/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 96dab76da3b3..59ce8943151f 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1906,6 +1906,7 @@ config KEXEC
bool "Kexec system call (EXPERIMENTAL)"
depends on (!SMP || PM_SLEEP_SMP)
depends on !CPU_V7M
+ depends on MMU
select KEXEC_CORE
help
kexec is a system call that implements the ability to shutdown your
--
2.25.0
next reply other threads:[~2020-02-05 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-05 22:43 Stefan Agner [this message]
2020-02-05 23:53 ` [PATCH] arm: make kexec depend on MMU Russell King - ARM Linux admin
2020-02-06 0:10 ` Stefan Agner
2020-02-06 10:00 ` Vladimir Murzin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b595d37283f043df78259221f2b7d18e0cb0ce5.1580942558.git.stefan@agner.ch \
--to=stefan@agner.ch \
--cc=akpm@linux-foundation.org \
--cc=armlinux@m.disordat.com \
--cc=arnd@arndb.de \
--cc=benjamin.gaignard@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mchehab+samsung@kernel.org \
--cc=mhocko@suse.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).