From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06DEAC43441 for ; Sat, 17 Nov 2018 02:39:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CAFF0208E3 for ; Sat, 17 Nov 2018 02:39:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAFF0208E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731512AbeKQMyt (ORCPT ); Sat, 17 Nov 2018 07:54:49 -0500 Received: from mga17.intel.com ([192.55.52.151]:52130 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729843AbeKQMyt (ORCPT ); Sat, 17 Nov 2018 07:54:49 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Nov 2018 18:39:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,242,1539673200"; d="scan'208";a="96979585" Received: from allen-box.sh.intel.com (HELO [10.239.161.122]) ([10.239.161.122]) by FMSMGA003.fm.intel.com with ESMTP; 16 Nov 2018 18:39:47 -0800 Cc: baolu.lu@linux.intel.com, Kirti Wankhede , Alex Williamson , Joerg Roedel , David Woodhouse , ashok.raj@intel.com, sanjay.k.kumar@intel.com, jacob.jun.pan@intel.com, kevin.tian@intel.com, Jean-Philippe Brucker , yi.l.liu@intel.com, yi.y.sun@intel.com, peterx@redhat.com, tiwei.bie@intel.com, Zeng Xin , iommu@lists.linux-foundation.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jacob Pan Subject: Re: [PATCH v4 6/8] vfio/mdev: Add iommu place holders in mdev_device To: Christoph Hellwig References: <20181105073408.21815-1-baolu.lu@linux.intel.com> <20181105073408.21815-7-baolu.lu@linux.intel.com> <20181106165356.44b59ec3@w520.home> <7bfc2f2b-10e6-b53c-51f3-c6494b686aa3@nvidia.com> <25b9a20f-06b5-57ac-81f1-fd933845c77f@linux.intel.com> <20181116085714.GA13181@infradead.org> From: Lu Baolu Message-ID: <5b63b94f-c7e3-24bd-a462-3c050f22ecb4@linux.intel.com> Date: Sat, 17 Nov 2018 10:37:05 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181116085714.GA13181@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 11/16/18 4:57 PM, Christoph Hellwig wrote: > On Fri, Nov 16, 2018 at 09:20:48AM +0800, Lu Baolu wrote: >>> Please keep symbols mdev_set/get_iommu_device(dev, iommu_device) non-GPL >>> same as other exported symbols from mdev_core module. >> >> Yes. It will be fixed in the next version. > > No. mdev shall not be used to circumvent the exports in the generic > vfio code. Get it now. Thanks a lot. Best regards, Lu Baolu