Re: [PATCH v4 2/3] dt-bindings: phy: Add YAML schemas for Intel Combophy

[Dilip Kota <eswara.kota@linux.intel.com>]

On 3/3/2020 9:50 AM, Rob Herring wrote:
> On Mon, Mar 02, 2020 at 04:43:24PM +0800, Dilip Kota wrote:
>> Combophy subsystem provides PHY support to various
>> controllers, viz. PCIe, SATA and EMAC.
>> Adding YAML schemas for the same.
>>
>> Signed-off-by: Dilip Kota <eswara.kota@linux.intel.com>
>> ---
>> Changes on v4:
>>    No changes.
...
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/phy/phy-intel-combophy.h>
>> +    combophy@d0a00000 {
>> +        compatible = "intel,combophy-lgm", "intel,combo-phy";
>> +        clocks = <&cgu0 1>;
>> +        reg = <0xd0a00000 0x40000>,
>> +              <0xd0a40000 0x1000>;
>> +        reg-names = "core", "app";
>> +        resets = <&rcu0 0x50 6>,
>> +                 <&rcu0 0x50 17>;
>> +        reset-names = "phy", "core";
>> +        intel,syscfg = <&sysconf 0>;
>> +        intel,hsio = <&hsiol 0>;
>> +        intel,phy-mode = <COMBO_PHY_PCIE>;
>> +
>> +        phy@0 {
> You need a 'reg' property to go with a unit-address.
>
> Really, I'd just simplify this to make parent 'resets' be 4 entries and
> put '#phy-cells = <1>;' in the parent. Then you don't need these child
> nodes.
If child nodes are not present, use case like PCIe controller-0 using 
phy@0 and PCIe controller-1 using phy@1 wont be possible.
>
>> +            compatible = "intel,phydev";
>> +            #phy-cells = <0>;
>> +            resets = <&rcu0 0x50 23>;
>> +        };
>> +
>> +        phy@1 {
>> +            compatible = "intel,phydev";
>> +            #phy-cells = <0>;
>> +            resets = <&rcu0 0x50 24>;
>> +        };
>> +    };
>> diff --git a/include/dt-bindings/phy/phy-intel-combophy.h b/include/dt-bindings/phy/phy-intel-combophy.h
>> new file mode 100644
>> index 000000000000..bd7f6377f4ef
>> --- /dev/null
>> +++ b/include/dt-bindings/phy/phy-intel-combophy.h
>> @@ -0,0 +1,10 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +
>> +#ifndef _DT_BINDINGS_INTEL_COMBOPHY
>> +#define _DT_BINDINGS_INTEL_COMBOPHY
>> +
>> +#define COMBO_PHY_PCIE	0
>> +#define COMBO_PHY_XPCS	1
>> +#define COMBO_PHY_SATA	2
> Use the PHY_TYPE_* defines we already have and extend as you need to.

Sure, will do the same.

Regards,
Dilip

>
>> +
>> +#endif /* _DT_BINDINGS_INTEL_COMBOPHY*/
>> -- 
>> 2.11.0
>>