linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] perf/core: Mark expected switch fall-through
@ 2019-02-12 20:54 Gustavo A. R. Silva
  2019-02-28 21:31 ` Gustavo A. R. Silva
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-12 20:54 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Alexander Shishkin, Jiri Olsa, Namhyung Kim
  Cc: linux-kernel, Gustavo A. R. Silva, Kees Cook

In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

kernel/events/core.c: In function ‘perf_event_parse_addr_filter’:
kernel/events/core.c:9154:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
    kernel = 1;
    ~~~~~~~^~~
kernel/events/core.c:9156:3: note: here
   case IF_SRC_FILEADDR:
   ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 kernel/events/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index ac194d3aae32..343ee21ab958 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9152,6 +9152,7 @@ perf_event_parse_addr_filter(struct perf_event *event, char *fstr,
 		case IF_SRC_KERNELADDR:
 		case IF_SRC_KERNEL:
 			kernel = 1;
+			/* fall through */
 
 		case IF_SRC_FILEADDR:
 		case IF_SRC_FILE:
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] perf/core: Mark expected switch fall-through
  2019-02-12 20:54 [PATCH] perf/core: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-02-28 21:31 ` Gustavo A. R. Silva
  2019-03-01 13:53   ` Arnaldo Carvalho de Melo
  2019-03-09 14:40 ` [tip:perf/urgent] " tip-bot for Gustavo A. R. Silva
  2019-03-09 19:48 ` [tip:perf/urgent] perf: " tip-bot for Gustavo A. R. Silva
  2 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-28 21:31 UTC (permalink / raw)
  To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
	Alexander Shishkin, Jiri Olsa, Namhyung Kim
  Cc: linux-kernel, Kees Cook

Hi all,

Friendly ping:

Who can ack or review this, please?

Thanks
--
Gustavo

On 2/12/19 2:54 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
> 
> This patch fixes the following warning:
> 
> kernel/events/core.c: In function ‘perf_event_parse_addr_filter’:
> kernel/events/core.c:9154:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
>     kernel = 1;
>     ~~~~~~~^~~
> kernel/events/core.c:9156:3: note: here
>    case IF_SRC_FILEADDR:
>    ^~~~
> 
> Warning level 3 was used: -Wimplicit-fallthrough=3
> 
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>  kernel/events/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index ac194d3aae32..343ee21ab958 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -9152,6 +9152,7 @@ perf_event_parse_addr_filter(struct perf_event *event, char *fstr,
>  		case IF_SRC_KERNELADDR:
>  		case IF_SRC_KERNEL:
>  			kernel = 1;
> +			/* fall through */
>  
>  		case IF_SRC_FILEADDR:
>  		case IF_SRC_FILE:
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] perf/core: Mark expected switch fall-through
  2019-02-28 21:31 ` Gustavo A. R. Silva
@ 2019-03-01 13:53   ` Arnaldo Carvalho de Melo
  2019-03-01 15:50     ` Gustavo A. R. Silva
  0 siblings, 1 reply; 6+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-03-01 13:53 UTC (permalink / raw)
  To: Gustavo A. R. Silva
  Cc: Peter Zijlstra, Ingo Molnar, Alexander Shishkin, Jiri Olsa,
	Namhyung Kim, linux-kernel, Kees Cook

Em Thu, Feb 28, 2019 at 03:31:31PM -0600, Gustavo A. R. Silva escreveu:
> Hi all,
> 
> Friendly ping:
> 
> Who can ack or review this, please?

I'm applying it, thanks.

- Arnaldo
 
> Thanks
> --
> Gustavo
> 
> On 2/12/19 2:54 PM, Gustavo A. R. Silva wrote:
> > In preparation to enabling -Wimplicit-fallthrough, mark switch
> > cases where we are expecting to fall through.
> > 
> > This patch fixes the following warning:
> > 
> > kernel/events/core.c: In function ‘perf_event_parse_addr_filter’:
> > kernel/events/core.c:9154:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
> >     kernel = 1;
> >     ~~~~~~~^~~
> > kernel/events/core.c:9156:3: note: here
> >    case IF_SRC_FILEADDR:
> >    ^~~~
> > 
> > Warning level 3 was used: -Wimplicit-fallthrough=3
> > 
> > This patch is part of the ongoing efforts to enable
> > -Wimplicit-fallthrough.
> > 
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> > ---
> >  kernel/events/core.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/kernel/events/core.c b/kernel/events/core.c
> > index ac194d3aae32..343ee21ab958 100644
> > --- a/kernel/events/core.c
> > +++ b/kernel/events/core.c
> > @@ -9152,6 +9152,7 @@ perf_event_parse_addr_filter(struct perf_event *event, char *fstr,
> >  		case IF_SRC_KERNELADDR:
> >  		case IF_SRC_KERNEL:
> >  			kernel = 1;
> > +			/* fall through */
> >  
> >  		case IF_SRC_FILEADDR:
> >  		case IF_SRC_FILE:
> > 

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] perf/core: Mark expected switch fall-through
  2019-03-01 13:53   ` Arnaldo Carvalho de Melo
@ 2019-03-01 15:50     ` Gustavo A. R. Silva
  0 siblings, 0 replies; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-01 15:50 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo
  Cc: Peter Zijlstra, Ingo Molnar, Alexander Shishkin, Jiri Olsa,
	Namhyung Kim, linux-kernel, Kees Cook



On 3/1/19 7:53 AM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Feb 28, 2019 at 03:31:31PM -0600, Gustavo A. R. Silva escreveu:
>> Hi all,
>>
>> Friendly ping:
>>
>> Who can ack or review this, please?
> 
> I'm applying it, thanks.
> 

Great.

Thanks, Arnaldo.

--
Gustavo

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [tip:perf/urgent] perf/core: Mark expected switch fall-through
  2019-02-12 20:54 [PATCH] perf/core: Mark expected switch fall-through Gustavo A. R. Silva
  2019-02-28 21:31 ` Gustavo A. R. Silva
@ 2019-03-09 14:40 ` tip-bot for Gustavo A. R. Silva
  2019-03-09 19:48 ` [tip:perf/urgent] perf: " tip-bot for Gustavo A. R. Silva
  2 siblings, 0 replies; 6+ messages in thread
From: tip-bot for Gustavo A. R. Silva @ 2019-03-09 14:40 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: eranian, alexander.shishkin, torvalds, keescook, namhyung,
	vincent.weaver, acme, mingo, acme, tglx, riel, jolsa,
	linux-kernel, bp, luto, dave.hansen, gustavo, peterz, hpa

Commit-ID:  43aa378b41700650e4ddbd068650f9fe4ab496df
Gitweb:     https://git.kernel.org/tip/43aa378b41700650e4ddbd068650f9fe4ab496df
Author:     Gustavo A. R. Silva <gustavo@embeddedor.com>
AuthorDate: Tue, 12 Feb 2019 14:54:30 -0600
Committer:  Ingo Molnar <mingo@kernel.org>
CommitDate: Sat, 9 Mar 2019 14:10:32 +0100

perf/core: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch fixes the following warning:

  kernel/events/core.c: In function ‘perf_event_parse_addr_filter’:
  kernel/events/core.c:9154:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
      kernel = 1;
      ~~~~~~~^~~
  kernel/events/core.c:9156:3: note: here
     case IF_SRC_FILEADDR:
     ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Rik van Riel <riel@surriel.com>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Link: https://lkml.kernel.org/r/20190212205430.GA8446@embeddedor
Signed-off-by: Ingo Molnar <mingo@kernel.org>
---
 kernel/events/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 5f59d848171e..68ff130b99e7 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9174,6 +9174,7 @@ perf_event_parse_addr_filter(struct perf_event *event, char *fstr,
 		case IF_SRC_KERNELADDR:
 		case IF_SRC_KERNEL:
 			kernel = 1;
+			/* fall through */
 
 		case IF_SRC_FILEADDR:
 		case IF_SRC_FILE:

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [tip:perf/urgent] perf: Mark expected switch fall-through
  2019-02-12 20:54 [PATCH] perf/core: Mark expected switch fall-through Gustavo A. R. Silva
  2019-02-28 21:31 ` Gustavo A. R. Silva
  2019-03-09 14:40 ` [tip:perf/urgent] " tip-bot for Gustavo A. R. Silva
@ 2019-03-09 19:48 ` tip-bot for Gustavo A. R. Silva
  2 siblings, 0 replies; 6+ messages in thread
From: tip-bot for Gustavo A. R. Silva @ 2019-03-09 19:48 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: acme, gustavo, tglx, peterz, linux-kernel, jolsa, namhyung,
	keescook, alexander.shishkin, mingo, hpa

Commit-ID:  10c3405f060397e565e4f75c403859f9a074bfa5
Gitweb:     https://git.kernel.org/tip/10c3405f060397e565e4f75c403859f9a074bfa5
Author:     Gustavo A. R. Silva <gustavo@embeddedor.com>
AuthorDate: Tue, 12 Feb 2019 14:54:30 -0600
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Fri, 1 Mar 2019 10:54:00 -0300

perf: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

This patch fixes the following warning:

  kernel/events/core.c: In function ‘perf_event_parse_addr_filter’:
  kernel/events/core.c:9154:11: warning: this statement may fall through [-Wimplicit-fallthrough=]
      kernel = 1;
      ~~~~~~~^~~
  kernel/events/core.c:9156:3: note: here
     case IF_SRC_FILEADDR:
     ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Gustavo A. R. Silva <gustavo@embeddedor.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Kees Kook <keescook@chromium.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20190212205430.GA8446@embeddedor
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 kernel/events/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index dd9698ad3d66..6fb27b564730 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -9175,6 +9175,7 @@ perf_event_parse_addr_filter(struct perf_event *event, char *fstr,
 		case IF_SRC_KERNELADDR:
 		case IF_SRC_KERNEL:
 			kernel = 1;
+			/* fall through */
 
 		case IF_SRC_FILEADDR:
 		case IF_SRC_FILE:

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-09 19:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-12 20:54 [PATCH] perf/core: Mark expected switch fall-through Gustavo A. R. Silva
2019-02-28 21:31 ` Gustavo A. R. Silva
2019-03-01 13:53   ` Arnaldo Carvalho de Melo
2019-03-01 15:50     ` Gustavo A. R. Silva
2019-03-09 14:40 ` [tip:perf/urgent] " tip-bot for Gustavo A. R. Silva
2019-03-09 19:48 ` [tip:perf/urgent] perf: " tip-bot for Gustavo A. R. Silva

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).