From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Dave Young <dyoung@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-doc@vger.kernel.org, mcgrof@kernel.org,
keescook@chromium.org, yzaikin@google.com,
akpm@linux-foundation.org, feng.tang@intel.com,
siglesias@igalia.com, kernel@gpiccoli.net,
kexec@lists.infradead.org
Subject: Re: [PATCH 3/3] panic: Allow printing extra panic information on kdump
Date: Sat, 25 Dec 2021 16:21:17 -0300 [thread overview]
Message-ID: <5b817a4f-0bba-7d79-8aab-33c58e922293@igalia.com> (raw)
In-Reply-To: <YcUj0EJvQt77OVs2@dhcp-128-65.nay.redhat.com>
On 23/12/2021 22:35, Dave Young wrote:
> Hi Guilherme,
> [...]
> If only the doc update, I think it is fine to be another follup-up
> patch.
>
> About your 1st option in patch log, there is crash_kexec_post_notifiers
> kernel param which can be used to switch on panic notifiers before kdump
> bootup. Another way probably you can try to move panic print to be
> panic notifier. Have this been discussed before?
>
Hey Dave, thanks for the suggestion. I've considered that but didn't
like the idea. My reasoning was: allowing post notifiers on kdump will
highly compromise the reliability, whereas the panic_print is a solo
option, and not very invasive.
To mix it with all panic notifiers would just increase a lot the risk of
a kdump failure. Put in other words: if I'm a kdump user and in order to
have this panic_print setting I'd also need to enable post notifiers,
certainly I'll not use the feature, 'cause I don't wanna risk kdump too
much.
One other option I've considered however, and I'd appreciate your
opinion here, would be a new option on crash_kexec_post_notifiers that
allows the users to select *which few notifiers* they want to enable.
Currently it's all or nothing, and this approach is too heavy/risky I
believe. Allowing customization on which post notifiers the user wants
would be much better and in this case, having a post notifier for
panic_print makes a lot of sense. What do you think?
Thanks!
next prev parent reply other threads:[~2021-12-25 19:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-09 20:28 [PATCH 0/3] Some improvements on panic_print Guilherme G. Piccoli
2021-11-09 20:28 ` [PATCH 1/3] docs: sysctl/kernel: Add missing bit to panic_print Guilherme G. Piccoli
2021-11-30 5:09 ` Feng Tang
2021-11-09 20:28 ` [PATCH 2/3] panic: Add option to dump all CPUs backtraces in panic_print Guilherme G. Piccoli
2021-11-30 5:12 ` Feng Tang
2021-12-03 15:09 ` Guilherme G. Piccoli
2021-12-19 20:11 ` Luis Chamberlain
2021-12-20 12:38 ` Guilherme G. Piccoli
2021-12-21 23:48 ` Andrew Morton
2021-12-22 12:37 ` Guilherme G. Piccoli
2022-01-13 9:31 ` Petr Mladek
2021-11-09 20:28 ` [PATCH 3/3] panic: Allow printing extra panic information on kdump Guilherme G. Piccoli
2021-12-22 11:45 ` Dave Young
2021-12-22 12:34 ` Guilherme G. Piccoli
2021-12-24 1:35 ` Dave Young
2021-12-25 19:21 ` Guilherme G. Piccoli [this message]
2021-12-27 1:45 ` Dave Young
2021-12-27 3:14 ` Guilherme G. Piccoli
2022-01-13 9:02 ` Petr Mladek
2022-01-13 13:00 ` Guilherme G. Piccoli
2022-01-27 16:53 ` Guilherme G. Piccoli
2022-02-08 18:12 ` Guilherme G. Piccoli
2022-02-08 21:39 ` Stephen Rothwell
2022-02-09 15:06 ` Guilherme G. Piccoli
2022-02-09 23:26 ` Stephen Rothwell
2022-02-10 12:50 ` Guilherme G. Piccoli
2021-11-26 21:34 ` [PATCH 0/3] Some improvements on panic_print Guilherme G. Piccoli
2021-12-14 16:31 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b817a4f-0bba-7d79-8aab-33c58e922293@igalia.com \
--to=gpiccoli@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=feng.tang@intel.com \
--cc=keescook@chromium.org \
--cc=kernel@gpiccoli.net \
--cc=kexec@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=siglesias@igalia.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).