From: John Hubbard <jhubbard@nvidia.com>
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>,
Jonathan Corbet <corbet@lwn.net>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] checkpatch: support "base-commit:" format
Date: Wed, 12 Feb 2020 20:22:14 -0800 [thread overview]
Message-ID: <5b8d6faf-4eec-ae8a-42e4-0b16713ed288@nvidia.com> (raw)
In-Reply-To: <2dab786b686735ec0c4ee614c64448d78c67a51d.camel@perches.com>
On 2/12/20 5:32 PM, Joe Perches wrote:
> On Wed, 2020-02-12 at 17:06 -0800, Joe Perches wrote:
>> On Wed, 2020-02-12 at 15:32 -0800, John Hubbard wrote:
>>> In order to support the get-lore-mbox.py tool described in [1], I ran:
>>>
>>> git format-patch --base=<commit> --cover-letter <revrange>
>>>
>>> ...which generated a "base-commit: <commit-hash>" tag at the end of the
>>> cover letter. However, checkpatch.pl generated an error upon encounting
>>> "base-commit:" in the cover letter:
>>>
>>> "ERROR: Please use git commit description style..."
>>>
>>> ...because it found the "commit" keyword, and failed to recognize that
>>> it was part of the "base-commit" phrase, and as such, should not be
>>> subjected to the same commit description style rules.
>>>
>>> Update checkpatch.pl to include a special case for "base-commit:", so
>>> that that tag no longer generates a checkpatch error.
> []
>>> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
>>> @@ -2761,6 +2761,7 @@ sub process {
>>>
>>> # Check for git id commit length and improperly formed commit descriptions
>>> if ($in_commit_log && !$commit_log_possible_stack_dump &&
>>> + $line !~ /base-commit:/ &&
>>
>> If this base-commit: entry is only at the start of line,
As far as I can tell, we should be able to rely on that, yes.
>> I presume this should actually be
>>
>> $line !~ /^base-commit:/ &&
>> or maybe
>> $line !~ /^\s*base-commit:/ &&
>>
>>> $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink):/i &&
>
> and probably better to just add it to this line instead like
>
> $line !~ /^\s*(?:Link|Patchwork|http|https|BugLink|base-commit):/i &&
>
Yes, that looks nice. I'll send a v2 doing it that way.
thanks,
--
John Hubbard
NVIDIA
prev parent reply other threads:[~2020-02-13 4:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 23:32 [PATCH 0/1] checkpatch: support "base-commit:" format John Hubbard
2020-02-12 23:32 ` [PATCH 1/1] " John Hubbard
2020-02-13 1:06 ` Joe Perches
2020-02-13 1:32 ` Joe Perches
2020-02-13 4:22 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b8d6faf-4eec-ae8a-42e4-0b16713ed288@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=apw@canonical.com \
--cc=corbet@lwn.net \
--cc=joe@perches.com \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).