From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Roger Quadros <rogerq@ti.com>, peter.chen@freescale.com
Cc: balbi@kernel.org, tony@atomide.com, gregkh@linuxfoundation.org,
dan.j.williams@intel.com, mathias.nyman@linux.intel.com,
Joao.Pinto@synopsys.com, jun.li@freescale.com,
grygorii.strashko@ti.com, yoshihiro.shimoda.uh@renesas.com,
robh@kernel.org, nsekhar@ti.com, b-liu@ti.com,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v9 03/14] usb: hcd.h: Add OTG to HCD interface
Date: Wed, 8 Jun 2016 14:39:07 +0300 [thread overview]
Message-ID: <5bc321c0-fb36-7a4a-d054-ee73b12822d4@cogentembedded.com> (raw)
In-Reply-To: <1465376626-30122-4-git-send-email-rogerq@ti.com>
Hello.
On 6/8/2016 12:03 PM, Roger Quadros wrote:
> The OTG core will use struct otg_hcd_ops to interface
> with the HCD controller.
Host controller driver (HCD) controller? Maybe just HC? :-)
> The main purpose of this interface is to avoid directly
> calling HCD APIs from the OTG core as they
> wouldn't be defined in the built-in symbol table if
> CONFIG_USB is m.
>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Acked-by: Peter Chen <peter.chen@nxp.com>
> ---
> include/linux/usb/hcd.h | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index 66fc137..7914bed 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -400,6 +400,30 @@ struct hc_driver {
>
> };
>
> +/**
> + * struct otg_hcd_ops - Interface between OTG core and HCD
> + *
> + * Provided by the HCD core to allow the OTG core to interface with the HCD
> + *
> + * @add: function to add the HCD
> + * @remove: function to remove the HCD
> + * @usb_bus_start_enum: function to immediately start bus enumeration
> + * @usb_control_msg: function to build and send of a control urb
That "of" is not needed. And it's URB.
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-06-08 11:39 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 9:03 [PATCH v9 00/14] USB OTG/dual-role framework Roger Quadros
2016-06-08 9:03 ` [PATCH v9 01/14] usb: hcd: Initialize hcd->flags to 0 Roger Quadros
2016-06-08 9:03 ` [PATCH v9 02/14] usb: otg-fsm: Prevent build warning "VDBG" redefined Roger Quadros
2016-06-08 9:03 ` [PATCH v9 03/14] usb: hcd.h: Add OTG to HCD interface Roger Quadros
2016-06-08 11:39 ` Sergei Shtylyov [this message]
2016-06-08 12:04 ` Roger Quadros
2016-06-08 12:10 ` Sergei Shtylyov
2016-06-09 7:31 ` Roger Quadros
2016-06-09 10:16 ` Sergei Shtylyov
2016-06-09 14:11 ` Alan Stern
2016-06-10 7:01 ` Roger Quadros
2016-06-09 7:51 ` [PATCH v10 " Roger Quadros
2016-06-08 9:03 ` [PATCH v9 04/14] usb: otg-fsm: use usb_otg wherever possible Roger Quadros
2016-06-08 9:03 ` [PATCH v9 05/14] usb: otg-fsm: move host controller operations into usb_otg->hcd_ops Roger Quadros
2016-06-08 9:03 ` [PATCH v9 06/14] usb: gadget.h: Add OTG to gadget interface Roger Quadros
2016-06-08 9:03 ` [PATCH v9 07/14] usb: otg: get rid of CONFIG_USB_OTG_FSM in favour of CONFIG_USB_OTG Roger Quadros
2016-06-08 9:03 ` [PATCH v9 08/14] usb: otg: add OTG/dual-role core Roger Quadros
2016-06-08 9:53 ` Peter Chen
2016-06-08 10:12 ` Roger Quadros
2016-06-08 12:42 ` Peter Chen
2016-06-09 7:24 ` Roger Quadros
2016-06-12 6:26 ` Peter Chen
2016-06-12 10:56 ` Peter Chen
2016-06-09 7:53 ` [PATCH v10 " Roger Quadros
2016-06-09 12:34 ` Sergei Shtylyov
2016-06-10 7:04 ` Roger Quadros
2016-06-10 10:19 ` Roger Quadros
2016-06-10 10:44 ` Sergei Shtylyov
2016-06-10 10:54 ` Roger Quadros
2016-06-10 11:02 ` Felipe Balbi
2016-06-08 9:03 ` [PATCH v9 09/14] usb: of: add an API to get OTG device from USB controller node Roger Quadros
2016-06-08 9:03 ` [PATCH v9 10/14] usb: otg: add hcd companion support Roger Quadros
2016-06-08 9:03 ` [PATCH v9 11/14] usb: otg: use dev_dbg() instead of VDBG() Roger Quadros
2016-06-08 15:10 ` Joe Perches
2016-06-09 7:25 ` Roger Quadros
2016-06-09 7:55 ` [PATCH v10 " Roger Quadros
2016-06-09 15:43 ` Joe Perches
2016-06-10 7:05 ` Roger Quadros
2016-06-08 9:03 ` [PATCH v9 12/14] usb: hcd: Adapt to OTG core Roger Quadros
2016-06-08 11:42 ` Sergei Shtylyov
2016-06-08 12:06 ` Roger Quadros
2016-06-08 12:11 ` Sergei Shtylyov
2016-06-09 7:27 ` Roger Quadros
2016-06-08 9:03 ` [PATCH v9 13/14] usb: gadget: udc: adapt " Roger Quadros
2016-06-09 10:49 ` Yoshihiro Shimoda
2016-06-10 7:06 ` Roger Quadros
2016-06-08 9:03 ` [PATCH v9 14/14] usb: host: xhci-plat: Add otg device to platform data Roger Quadros
2016-06-09 5:27 ` [PATCH v9 00/14] USB OTG/dual-role framework Peter Chen
2016-06-09 7:30 ` Roger Quadros
2016-06-09 10:13 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc321c0-fb36-7a4a-d054-ee73b12822d4@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Joao.Pinto@synopsys.com \
--cc=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=jun.li@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=nsekhar@ti.com \
--cc=peter.chen@freescale.com \
--cc=robh@kernel.org \
--cc=rogerq@ti.com \
--cc=tony@atomide.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).