From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B4E3C433FE for ; Thu, 17 Feb 2022 22:16:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343838AbiBQWRH (ORCPT ); Thu, 17 Feb 2022 17:17:07 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:39010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343832AbiBQWRD (ORCPT ); Thu, 17 Feb 2022 17:17:03 -0500 Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE8A61662E0 for ; Thu, 17 Feb 2022 14:16:45 -0800 (PST) Received: by mail-oo1-xc2c.google.com with SMTP id s203-20020a4a3bd4000000b003191c2dcbe8so1300946oos.9 for ; Thu, 17 Feb 2022 14:16:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kali.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=3Qu8seh4Erze8eL9+0IzxF6u8DsEwe3aHTII3NoEQbE=; b=lkCn22DouqlTdK8owy6Rxc2C+gzFjraIPgRjzRk2l9lkxHw9kfi+nQ3+3mVt8N4XRe oHGu2GJXKn9wbmHDS2SAJgsP1F872qP11Pj5Xvy4ezv9Wfuq6EogtSPLwGD9hoSqUUc1 ZES0CKmFvIydFeZQOQ3hSBi9vpNvUsujOTZk1eCFtrCv+wcOjAxccOP+BuCIc5jNB/Qb tlWzwQPtt+vDm+ffZ+oYbqGIYbqBw3K8xhro/YpaXVXSXEQe8bgHh5/7+zVpHeuXeNGw 2AgpEm0x+111s+YA3v18d87MWF892Fy47QC0WXxFj0JSZ4Vq4Z+nO97Wl71d3mgNL2xo QF4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3Qu8seh4Erze8eL9+0IzxF6u8DsEwe3aHTII3NoEQbE=; b=pBa1pfM9gDxUKYf72RWoUee4rq3QjRMGDTeApa7dz6TWvaE74CZwPMmQMoMwSuZO7y P+2FfVTcEHNayc3XaE8YcFhnpFxlmrQe/Um6N+NSCypnEONOrnnFH4YN5h27U4PZSLsK 4EJ1OjEzUFSlQxCWKvhdbwlSuzFjCBOELYED7EFtNKMgMUhoRKwNafvU4BXLX6A90K8n yv6If0MPet0m/uU4l21nuTGcFN0Mvsn4ZV28u0i3RjbiyWhzY2WRD964hFWUKVnKfrcW /m60qaRiIn1aHU9aO1ZKilrBU5AGb/195pSyliEWgadnDD1adLO1eI9UaaEraF10h21b z/LA== X-Gm-Message-State: AOAM532TEEgW3J651kGU8457W49sSljCH8zWrXSwt8x4haw+z2oB8vC9 k6rp3R87dIjX0Tdmo+sHOrtYAA== X-Google-Smtp-Source: ABdhPJzptwAO0OnmpuzRq2rLwK8dCCZXdwiu3z4y+uJud/SrSlSKf5pCZV7ZlUaEHwAHDPPdWVYJhA== X-Received: by 2002:a05:6870:9893:b0:d2:87e4:c71c with SMTP id eg19-20020a056870989300b000d287e4c71cmr1788986oab.132.1645136205008; Thu, 17 Feb 2022 14:16:45 -0800 (PST) Received: from [192.168.11.51] (cpe-173-173-107-246.satx.res.rr.com. [173.173.107.246]) by smtp.gmail.com with ESMTPSA id k17sm518081otk.80.2022.02.17.14.16.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Feb 2022 14:16:44 -0800 (PST) Message-ID: <5bc3b4d9-1bbb-479a-64f4-768f47075ec0@kali.org> Date: Thu, 17 Feb 2022 16:16:42 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v10 6/6] usb: dwc3: qcom: Enable the interrupts during probe Content-Language: en-US To: Sandeep Maheswaram , Pavan Kondeti Cc: Greg Kroah-Hartman , Felipe Balbi , Stephen Boyd , Doug Anderson , Matthias Kaehlcke , Mathias Nyman , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, quic_ppratap@quicinc.com References: <1642398248-21753-1-git-send-email-quic_c_sanm@quicinc.com> <1642398248-21753-7-git-send-email-quic_c_sanm@quicinc.com> <93b68251-7e7e-ac92-fb47-346c410744b2@kali.org> <20220118095255.GB11385@hu-pkondeti-hyd.qualcomm.com> <78c90e46-666b-bc9b-235d-ae4c69e19929@quicinc.com> <601cdc74-392f-dd4f-7ea0-8e65c6b6d7e2@quicinc.com> <52b37547-3e78-b18c-307d-7eedf5baab0d@kali.org> <0e006cc0-2760-195a-35b9-0a2f6e8452c5@quicinc.com> <47ae3e73-5880-bfb7-fc14-7dd95a75ce14@kali.org> <55aa0436-64f5-1ecb-d95d-721e45f6fb95@kali.org> From: Steev Klimaszewski In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sandeep, On 2/17/22 12:05 AM, Sandeep Maheswaram wrote: > > Hi Steev, > > On 2/16/2022 3:21 PM, Steev Klimaszewski wrote: >> That does allow it to boot, however.... it breaks USB. >> >> [    2.013325] genirq: Setting trigger mode 3 for irq 35 failed >> (gic_set_type+0x0/0x1b0) >> [    2.014063] dwc3-qcom a6f8800.usb: dp_hs_phy_irq failed: -22 >> [    2.014134] dwc3-qcom a6f8800.usb: failed to setup IRQs, err=-22 >> [    2.014351] dwc3-qcom: probe of a6f8800.usb failed with error -22 >> [    2.018496] genirq: Setting trigger mode 3 for irq 39 failed >> (gic_set_type+0x0/0x1b0) >> [    2.019124] dwc3-qcom a8f8800.usb: dp_hs_phy_irq failed: -22 >> [    2.019193] dwc3-qcom a8f8800.usb: failed to setup IRQs, err=-22 >> [    2.019372] dwc3-qcom: probe of a8f8800.usb failed with error -22 >> >> steev@limitless:~$ lsusb >> steev@limitless:~$ >> >> >> -- steev >> > Can you try with only IRQ_TYPE_EDGE_RISING as you are using GIC > interrupts  where IRQ_TYPE_EDGE_FALLING may not be supported > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi > b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 0d6286d..ee3b031 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -3796,8 +3796,8 @@ > >                         interrupts = , >                                      , > -                                    , > -                                    ; > +                                    , > +                                    ; >                         interrupt-names = "hs_phy_irq", "ss_phy_irq", >                                           "dm_hs_phy_irq", > "dp_hs_phy_irq"; > > @@ -3844,8 +3844,8 @@ > >                         interrupts = , >                                      , > -                                    , > -                                    ; > +                                    , > +                                    ; >                         interrupt-names = "hs_phy_irq", "ss_phy_irq", >                                           "dm_hs_phy_irq", > "dp_hs_phy_irq"; > Regards > > Sandeep > With this change, and with either EDGE_RISING or EDGE_BOTH in the lenovo yoga c630 dts, it does indeed boot.  Leaving LEVEL_HIGH in the c630, it does also boot, but there is a delay of about 30 seconds (I'm assuming interrupt storm?) during the boot. -- steev