From: Bjorn Helgaas <helgaas@kernel.org>
To: Suganath Prabu <suganath-prabu.subramani@broadcom.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Sathya.Prakash@broadcom.com, sreekanth.reddy@broadcom.com,
Suganath Prabu <suganath-prabu.subramani@broadcom.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: RE: [PATCH v7 0/8] mpt3sas: some bug fixes patches
Date: Fri, 02 Nov 2018 13:25:58 -0500 [thread overview]
Message-ID: <5bdc96b6a91b2_2e7982af9fe8650b0ba@bhelgaas-glaptop.notmuch> (raw)
In-Reply-To: <1540992219-20291-1-git-send-email-suganath-prabu.subramani@broadcom.com>
Suganath Prabu wrote:
> V7 Change Set:
> Split some patches into multiple small patches
> as suggested by Bjorn Helgaas
>
> v6 Change Set:
> Incorporated changes as suggested by Andy.
> In Patch 1 converted while loop to do while in
> function mpt3sas_wait_for_ioc_to_operational().
> And in patch 3 removed parentheses.
>
> V5 Change Set:
> V5 post has only defect fixes.
> We are reworking and incorporating the suggestions from Bjorn.
> And after covering tests, we ll be post Hot-Plug Surprise
> removal patches.
>
> V4 Change Set:
> Reframe split strings in print statement, to avoid
>
> V3 Change Set:
> Simplified function "mpt3sas_base_pci_device_is_available" and
> made inline
>
> V2 Change Set:
> Replaced mpt3sas_base_pci_device_is_unplugged with
> pci_device_is_present.
>
> V1 Chnage Set:
> In Patch 0001 - unlock mutex, if active reset is in progress.
>
> Suganath Prabu (8):
> mpt3sas: Added new #define variable IOC_OPERATIONAL_WAIT_COUNT
> mpt3sas: Separate out mpt3sas_wait_for_ioc
> mpt3sas: Refactor mpt3sas_wait_for_ioc function
> mpt3sas: Call sas_remove_host before removing the target devices
> mpt3sas: Fix Sync cache command failure during driver unload
> mpt3sas: Don't modify EEDPTagMode field setting on SAS3.5 HBA devices
> mpt3sas: Fix driver modifying persistent data in Manufacturing page11
> mpt3sas: Bump driver version to 27.100.00.00.
>
> drivers/scsi/mpt3sas/mpt3sas_base.c | 73 +++++++++++++------------
> drivers/scsi/mpt3sas/mpt3sas_base.h | 8 ++-
> drivers/scsi/mpt3sas/mpt3sas_config.c | 27 ++--------
> drivers/scsi/mpt3sas/mpt3sas_ctl.c | 21 ++------
> drivers/scsi/mpt3sas/mpt3sas_scsih.c | 38 ++++++++++++-
> drivers/scsi/mpt3sas/mpt3sas_transport.c | 91 ++++++--------------------------
> 6 files changed, 106 insertions(+), 152 deletions(-)
>
> --
> 1.8.3.1
These all look fine to me. I'm only looking at the code structure; I
have no idea how the mpt3sas hardware or the SCSI mid-layer work, so
you're on your own there :)
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
Andy also gave his reviewed-by on the v6 series, so I cc'd him here.
I think it's good practice to specifically cc anybody who has
commented on previous versions of your patch set.
next prev parent reply other threads:[~2018-11-02 18:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 13:23 [PATCH v7 0/8] mpt3sas: some bug fixes patches Suganath Prabu
2018-10-31 13:23 ` [PATCH v7 1/8] mpt3sas: Added new #define variable IOC_OPERATIONAL_WAIT_COUNT Suganath Prabu
2018-10-31 13:23 ` [PATCH v7 2/8] mpt3sas: Separate out mpt3sas_wait_for_ioc Suganath Prabu
2018-10-31 13:23 ` [PATCH v7 3/8] mpt3sas: Refactor mpt3sas_wait_for_ioc function Suganath Prabu
2018-10-31 13:23 ` [PATCH v7 4/8] mpt3sas: Call sas_remove_host before removing the target devices Suganath Prabu
2018-10-31 13:23 ` [PATCH v7 5/8] mpt3sas: Fix Sync cache command failure during driver unload Suganath Prabu
2018-10-31 13:23 ` [PATCH v7 6/8] mpt3sas: Don't modify EEDPTagMode field setting on SAS3.5 HBA devices Suganath Prabu
2018-10-31 13:23 ` [PATCH v7 7/8] mpt3sas: Fix driver modifying persistent data in Manufacturing page11 Suganath Prabu
2018-10-31 13:23 ` [PATCH v7 8/8] mpt3sas: Bump driver version to 27.100.00.00 Suganath Prabu
2018-11-02 18:25 ` Bjorn Helgaas [this message]
2018-11-02 18:35 ` [PATCH v7 0/8] mpt3sas: some bug fixes patches Andy Shevchenko
2018-11-07 1:45 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bdc96b6a91b2_2e7982af9fe8650b0ba@bhelgaas-glaptop.notmuch \
--to=helgaas@kernel.org \
--cc=Sathya.Prakash@broadcom.com \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sreekanth.reddy@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).