* [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent
@ 2018-11-09 16:50 Sabyasachi Gupta
2018-11-12 15:28 ` Steve Wise
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sabyasachi Gupta @ 2018-11-09 16:50 UTC (permalink / raw)
To: swise, dledford, jgg
Cc: jrdr.linux, linux-rdma, linux-kernel, brajeswar.linux
Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
---
drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_hal.c
index dcb4bba..df4f7a3 100644
--- a/drivers/infiniband/hw/cxgb3/cxio_hal.c
+++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c
@@ -291,13 +291,12 @@ int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain,
if (!wq->sq)
goto err3;
- wq->queue = dma_alloc_coherent(&(rdev_p->rnic_info.pdev->dev),
+ wq->queue = dma_zalloc_coherent(&(rdev_p->rnic_info.pdev->dev),
depth * sizeof(union t3_wr),
&(wq->dma_addr), GFP_KERNEL);
if (!wq->queue)
goto err4;
- memset(wq->queue, 0, depth * sizeof(union t3_wr));
dma_unmap_addr_set(wq, mapping, wq->dma_addr);
wq->doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr;
if (!kernel_domain)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent
2018-11-09 16:50 [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent Sabyasachi Gupta
@ 2018-11-12 15:28 ` Steve Wise
2018-11-12 15:31 ` Steve Wise
2018-11-21 22:59 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Steve Wise @ 2018-11-12 15:28 UTC (permalink / raw)
To: Sabyasachi Gupta, dledford, jgg
Cc: jrdr.linux, linux-rdma, linux-kernel, brajeswar.linux
On 11/9/2018 10:50 AM, Sabyasachi Gupta wrote:
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
> drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_hal.c
> index dcb4bba..df4f7a3 100644
> --- a/drivers/infiniband/hw/cxgb3/cxio_hal.c
> +++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c
> @@ -291,13 +291,12 @@ int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain,
> if (!wq->sq)
> goto err3;
>
> - wq->queue = dma_alloc_coherent(&(rdev_p->rnic_info.pdev->dev),
> + wq->queue = dma_zalloc_coherent(&(rdev_p->rnic_info.pdev->dev),
> depth * sizeof(union t3_wr),
> &(wq->dma_addr), GFP_KERNEL);
> if (!wq->queue)
> goto err4;
>
> - memset(wq->queue, 0, depth * sizeof(union t3_wr));
> dma_unmap_addr_set(wq, mapping, wq->dma_addr);
> wq->doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr;
> if (!kernel_domain)
>
Acked-by: Steve Wise <swise@opengridcomputing.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent
2018-11-09 16:50 [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent Sabyasachi Gupta
2018-11-12 15:28 ` Steve Wise
@ 2018-11-12 15:31 ` Steve Wise
2018-11-21 22:59 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Steve Wise @ 2018-11-12 15:31 UTC (permalink / raw)
To: Sabyasachi Gupta, dledford, jgg
Cc: jrdr.linux, linux-rdma, linux-kernel, brajeswar.linux
On 11/9/2018 10:50 AM, Sabyasachi Gupta wrote:
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> ---
> drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_hal.c
> index dcb4bba..df4f7a3 100644
> --- a/drivers/infiniband/hw/cxgb3/cxio_hal.c
> +++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c
> @@ -291,13 +291,12 @@ int cxio_create_qp(struct cxio_rdev *rdev_p, u32 kernel_domain,
> if (!wq->sq)
> goto err3;
>
> - wq->queue = dma_alloc_coherent(&(rdev_p->rnic_info.pdev->dev),
> + wq->queue = dma_zalloc_coherent(&(rdev_p->rnic_info.pdev->dev),
> depth * sizeof(union t3_wr),
> &(wq->dma_addr), GFP_KERNEL);
> if (!wq->queue)
> goto err4;
>
> - memset(wq->queue, 0, depth * sizeof(union t3_wr));
> dma_unmap_addr_set(wq, mapping, wq->dma_addr);
> wq->doorbell = (void __iomem *)rdev_p->rnic_info.kdb_addr;
> if (!kernel_domain)
>
Acked-by: Steve Wise <swise@opengridcomputing.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent
2018-11-09 16:50 [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent Sabyasachi Gupta
2018-11-12 15:28 ` Steve Wise
2018-11-12 15:31 ` Steve Wise
@ 2018-11-21 22:59 ` Jason Gunthorpe
2 siblings, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2018-11-21 22:59 UTC (permalink / raw)
To: Sabyasachi Gupta
Cc: swise, dledford, jrdr.linux, linux-rdma, linux-kernel, brajeswar.linux
On Fri, Nov 09, 2018 at 10:20:29PM +0530, Sabyasachi Gupta wrote:
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
>
> Signed-off-by: Sabyasachi Gupta <sabyasachi.linux@gmail.com>
> Acked-by: Steve Wise <swise@opengridcomputing.com>
> Acked-by: Steve Wise <swise@opengridcomputing.com>
> ---
> drivers/infiniband/hw/cxgb3/cxio_hal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied to for-next
Thanks,
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-21 22:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-09 16:50 [PATCH] infiniband/hw/cxgb3/cxio_hal.c: Use dma_zalloc_coherent Sabyasachi Gupta
2018-11-12 15:28 ` Steve Wise
2018-11-12 15:31 ` Steve Wise
2018-11-21 22:59 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).