From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-ext4@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
"Theodore Ts'o" <tytso@mit.edu>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect()
Date: Sat, 19 Aug 2017 13:47:40 +0200 [thread overview]
Message-ID: <5bf432ae-398d-718c-8105-3092a240a8ef@users.sourceforge.net> (raw)
In-Reply-To: <ca49a6dc-f2ee-d427-5f16-052706277b38@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sat, 19 Aug 2017 13:04:50 +0200
Omit an extra message for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
fs/ext4/mmp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/mmp.c b/fs/ext4/mmp.c
index eb9835638680..1ce00453f612 100644
--- a/fs/ext4/mmp.c
+++ b/fs/ext4/mmp.c
@@ -371,7 +371,6 @@ int ext4_multi_mount_protect(struct super_block *sb,
- if (!mmpd_data) {
- ext4_warning(sb, "not enough memory for mmpd_data");
+ if (!mmpd_data)
goto failed;
- }
+
mmpd_data->sb = sb;
mmpd_data->bh = bh;
--
2.14.0
next prev parent reply other threads:[~2017-08-19 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-19 11:46 [PATCH 0/2] fs-ext4: Adjustments for two function implementations SF Markus Elfring
2017-08-19 11:47 ` SF Markus Elfring [this message]
2017-08-19 17:08 ` [PATCH 1/2] ext4: Delete an error message for a failed memory allocation in ext4_multi_mount_protect() Eric Sandeen
2017-08-19 18:00 ` SF Markus Elfring
2017-08-24 17:44 ` Theodore Ts'o
2017-08-24 19:16 ` [PATCH 1/2] " Dan Carpenter
2017-08-19 11:48 ` [PATCH 2/2] ext4: Improve a size determination in two functions SF Markus Elfring
2017-08-20 1:49 ` Eric Sandeen
2017-08-24 17:50 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bf432ae-398d-718c-8105-3092a240a8ef@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=adilger.kernel@dilger.ca \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).