From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751503AbdEBHsf convert rfc822-to-8bit (ORCPT ); Tue, 2 May 2017 03:48:35 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:43577 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750864AbdEBHsc (ORCPT ); Tue, 2 May 2017 03:48:32 -0400 From: Olivier MOYSAN To: Rob Herring CC: "lgirdwood@gmail.com" , "broonie@kernel.org" , "perex@perex.cz" , "tiwai@suse.com" , "mcoquelin.stm32@gmail.com" , Alexandre TORGUE , "alsa-devel@alsa-project.org" , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" , "linux-kernel@vger.kernel.org" , Arnaud POULIQUEN , Benjamin GAIGNARD Subject: Re: [PATCH v3 1/2] ASoC: stm32: add bindings for SAI Thread-Topic: [PATCH v3 1/2] ASoC: stm32: add bindings for SAI Thread-Index: AQHSsg386jPOrPSqNUKjwY2EZfG0MqHbPXkAgAVtCgA= Date: Tue, 2 May 2017 07:45:35 +0000 Message-ID: <5bf88908-37ec-412f-9123-6f90938b5b66@st.com> References: <1491837596-2924-1-git-send-email-olivier.moysan@st.com> <1491837596-2924-2-git-send-email-olivier.moysan@st.com> <20170428205358.fxjqaki44xqim4ta@rob-hp-laptop> In-Reply-To: <20170428205358.fxjqaki44xqim4ta@rob-hp-laptop> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.45] Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-02_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Rob, On 04/28/2017 10:53 PM, Rob Herring wrote: > On Mon, Apr 10, 2017 at 05:19:55PM +0200, olivier moysan wrote: >> This patch adds documentation of device tree bindings for the >> STM32 SAI ASoC driver. >> >> Signed-off-by: olivier moysan >> --- >> .../devicetree/bindings/sound/st,stm32-sai.txt | 89 ++++++++++++++++++++++ >> 1 file changed, 89 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/sound/st,stm32-sai.txt >> >> diff --git a/Documentation/devicetree/bindings/sound/st,stm32-sai.txt b/Documentation/devicetree/bindings/sound/st,stm32-sai.txt >> new file mode 100644 >> index 0000000..c59a3d7 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/sound/st,stm32-sai.txt >> @@ -0,0 +1,89 @@ >> +STMicroelectronics STM32 Serial Audio Interface (SAI). > > [...] > >> + sai1b: audio-controller@40015824 { >> + #sound-dai-cells = <0>; >> + compatible = "st,stm32-sai-sub-b"; >> + reg = <0x40015824 0x1C>; >> + clocks = <&rcc 1 CLK_SAI2>; >> + clock-names = "sai_ck"; >> + dmas = <&dma2 5 0 0x400 0x0>; >> + dma-names = "tx"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pinctrl_sai1b>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + sai1b_port: port@0 { >> + reg = <0>; >> + cpu_endpoint: endpoint { >> + remote-endpoint = <&codec_endpoint>; >> + audio-graph-card,format = "i2s"; >> + audio-graph-card,bitclock-master = <&codec_endpoint>; >> + audio-graph-card,frame-master = <&codec_endpoint>; > > These property names are wrong. > I have taken into account this comment (and previous ones). They will be included in next update of this patch set. >> + }; >> + }; >> + }; >> + }; >> +}; >> + >> +audio-codec { >> + codec_port: port { >> + codec_endpoint: endpoint { >> + remote-endpoint = <&cpu_endpoint>; >> + }; >> + }; >> +}; >> -- >> 1.9.1 >> Best regards Olivier