From: Daniel Scally <djrscally@gmail.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-media@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net,
lenb@kernel.org, gregkh@linuxfoundation.org, yong.zhi@intel.com,
sakari.ailus@linux.intel.com, bingbu.cao@intel.com,
tian.shu.qiu@intel.com, mchehab@kernel.org,
robert.moore@intel.com, erik.kaneda@intel.com, pmladek@suse.com,
rostedt@goodmis.org, sergey.senozhatsky@gmail.com,
andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk,
laurent.pinchart+renesas@ideasonboard.com,
jacopo+renesas@jmondi.org,
kieran.bingham+renesas@ideasonboard.com,
linus.walleij@linaro.org, heikki.krogerus@linux.intel.com,
kitakar@gmail.com, jorhand@linux.microsoft.com
Subject: Re: [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver
Date: Fri, 18 Dec 2020 23:57:54 +0000 [thread overview]
Message-ID: <5c0ae9f8-ba58-a26c-400b-7d85d01087a3@gmail.com> (raw)
In-Reply-To: <X9zehD1xtQP/bxXu@pendragon.ideasonboard.com>
Hi Laurent - thanks for the comments
On 18/12/2020 16:53, Laurent Pinchart wrote:
>> +static void cio2_bridge_init_property_names(struct cio2_sensor *sensor)
>> +{
>> + strscpy(sensor->prop_names.clock_frequency, "clock-frequency",
>> + sizeof(sensor->prop_names.clock_frequency));
>> + strscpy(sensor->prop_names.rotation, "rotation",
>> + sizeof(sensor->prop_names.rotation));
>> + strscpy(sensor->prop_names.bus_type, "bus-type",
>> + sizeof(sensor->prop_names.bus_type));
>> + strscpy(sensor->prop_names.data_lanes, "data-lanes",
>> + sizeof(sensor->prop_names.data_lanes));
>> + strscpy(sensor->prop_names.remote_endpoint, "remote-endpoint",
>> + sizeof(sensor->prop_names.remote_endpoint));
>> + strscpy(sensor->prop_names.link_frequencies, "link-frequencies",
>> + sizeof(sensor->prop_names.link_frequencies));
>
> Just curious, was there anything not working correctly with the proposal
> I made ?
>
> static const struct cio2_property_names prop_names = {
> .clock_frequency = "clock-frequency",
> .rotation = "rotation",
> .bus_type = "bus-type",
> .data_lanes = "data-lanes",
> .remote_endpoint = "remote-endpoint",
> };
>
> static void cio2_bridge_init_property_names(struct cio2_sensor *sensor)
> {
> sensor->prop_names = prop_names;
> }
>
> It generates a warning when the string is too long for the field size,
> which should help catching issues at compilation time.
Yes, though I don't know how much of a real-world problem it would have
been - if you recall we have the issue that the device grabs a reference
to the software_nodes (after we stopped delaying until after the
i2c_client is available), which means we can't safely free the
cio2_bridge struct on module unload. That also means we can't rely on
those pointers to string literals existing, because if the ipu3-cio2
module gets unloaded they'll be gone.
Shame, as it's way neater.
>> +static void cio2_bridge_init_swnode_names(struct cio2_sensor *sensor)
>> +{
>> + snprintf(sensor->node_names.remote_port, 7, "port@%u", sensor->ssdb.link);
>> + strscpy(sensor->node_names.port, "port@0", sizeof(sensor->node_names.port));
>> + strscpy(sensor->node_names.endpoint, "endpoint@0", sizeof(sensor->node_names.endpoint));
>
> I'd wrap lines, but maybe that's because I'm an old-school, 80-columns
> programmer :-)
Heh sure, I'll wrap them.
>> +static int cio2_bridge_connect_sensors(struct cio2_bridge *bridge,
>> + struct pci_dev *cio2)
>> +{
>> + struct fwnode_handle *fwnode;
>> + struct cio2_sensor *sensor;
>> + struct acpi_device *adev;
>> + unsigned int i;
>> + int ret = 0;
>> +
>> + for (i = 0; i < ARRAY_SIZE(cio2_supported_sensors); i++) {
>> + const struct cio2_sensor_config *cfg = &cio2_supported_sensors[i];
>> +
>> + for_each_acpi_dev_match(adev, cfg->hid, NULL, -1) {
>> + if (bridge->n_sensors >= CIO2_NUM_PORTS) {
>> + dev_warn(&cio2->dev, "Exceeded available CIO2 ports\n");
>> + /* overflow i so outer loop ceases */
>> + i = ARRAY_SIZE(cio2_supported_sensors);
>> + break;
>
> Or just
>
> return 0;
>
> ?
Derp, yes of course.
>> +/* Data representation as it is in ACPI SSDB buffer */
>> +struct cio2_sensor_ssdb {
>> + u8 version; /* 0000 */
>> + u8 sku; /* 0001 */
>> + u8 guid_csi2[16]; /* 0002 */
>> + u8 devfunction; /* 0003 */
>> + u8 bus; /* 0004 */
>> + u32 dphylinkenfuses; /* 0005 */
>> + u32 clockdiv; /* 0009 */
>> + u8 link; /* 0013 */
>> + u8 lanes; /* 0014 */
>> + u32 csiparams[10]; /* 0015 */
>> + u32 maxlanespeed; /* 0019 */
>> + u8 sensorcalibfileidx; /* 0023 */
>> + u8 sensorcalibfileidxInMBZ[3]; /* 0024 */
>> + u8 romtype; /* 0025 */
>> + u8 vcmtype; /* 0026 */
>> + u8 platforminfo; /* 0027 */
>
> Why stop at 27 ? :-) I'd either go all the way, or not at all. It's also
> quite customary to represent offset as hex values, as that's what most
> hex editors / viewers will show.
Oops - that was actually just me debugging...I guess I might actually
finish it, converted to hex. It came in useful reading the DSDT to have
that somewhere easy to refer to.
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Nice - thank you!
next prev parent reply other threads:[~2020-12-18 23:58 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 23:43 [PATCH v2 00/12] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows Daniel Scally
2020-12-17 23:43 ` [PATCH v2 01/12] software_node: Fix refcounts in software_node_get_next_child() Daniel Scally
2020-12-21 9:08 ` Sakari Ailus
2020-12-17 23:43 ` [PATCH v2 02/12] property: Return true in fwnode_device_is_available for NULL ops Daniel Scally
2020-12-21 9:10 ` Sakari Ailus
2020-12-17 23:43 ` [PATCH v2 03/12] property: Call fwnode_graph_get_endpoint_by_id() for fwnode->secondary Daniel Scally
2020-12-17 23:43 ` [PATCH v2 04/12] software_node: Enforce parent before child ordering of nodes arrays Daniel Scally
2020-12-18 16:02 ` Laurent Pinchart
2020-12-18 22:19 ` Daniel Scally
2020-12-18 20:29 ` Andy Shevchenko
2020-12-19 23:33 ` Daniel Scally
2020-12-17 23:43 ` [PATCH v2 05/12] software_node: unregister software_nodes in reverse order Daniel Scally
2020-12-18 20:31 ` Andy Shevchenko
2020-12-21 9:21 ` Sakari Ailus
2020-12-21 11:26 ` Andy Shevchenko
2020-12-23 22:24 ` Daniel Scally
2020-12-17 23:43 ` [PATCH v2 06/12] software_node: Add support for fwnode_graph*() family of functions Daniel Scally
2020-12-18 16:22 ` Laurent Pinchart
2020-12-18 22:13 ` Daniel Scally
2020-12-18 23:46 ` Daniel Scally
2020-12-18 20:37 ` Andy Shevchenko
2020-12-18 22:26 ` Daniel Scally
2020-12-21 9:34 ` Sakari Ailus
2020-12-21 10:01 ` Daniel Scally
2020-12-17 23:43 ` [PATCH v2 07/12] lib/test_printf.c: Use helper function to unwind array of software_nodes Daniel Scally
2020-12-17 23:43 ` [PATCH v2 08/12] ipu3-cio2: Add T: entry to MAINTAINERS Daniel Scally
2020-12-17 23:43 ` [PATCH v2 09/12] ipu3-cio2: Rename ipu3-cio2.c Daniel Scally
2020-12-17 23:43 ` [PATCH v2 10/12] media: v4l2-core: v4l2-async: Check sd->fwnode->secondary in match_fwnode() Daniel Scally
2020-12-17 23:43 ` [PATCH v2 11/12] acpi: Add acpi_dev_get_next_match_dev() and helper macro Daniel Scally
2020-12-18 20:42 ` Andy Shevchenko
2020-12-21 9:47 ` Sakari Ailus
2020-12-17 23:43 ` [PATCH v2 12/12] ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver Daniel Scally
2020-12-18 16:53 ` Laurent Pinchart
2020-12-18 23:57 ` Daniel Scally [this message]
2020-12-19 0:39 ` Laurent Pinchart
2020-12-19 23:24 ` Daniel Scally
2020-12-18 21:17 ` Andy Shevchenko
2020-12-19 0:22 ` Daniel Scally
2020-12-19 18:52 ` Andy Shevchenko
2020-12-19 23:48 ` Daniel Scally
2020-12-21 10:21 ` Sakari Ailus
2020-12-21 10:52 ` Daniel Scally
2020-12-21 10:57 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c0ae9f8-ba58-a26c-400b-7d85d01087a3@gmail.com \
--to=djrscally@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=devel@acpica.org \
--cc=erik.kaneda@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jacopo+renesas@jmondi.org \
--cc=jorhand@linux.microsoft.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kitakar@gmail.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mchehab@kernel.org \
--cc=pmladek@suse.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=rostedt@goodmis.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tian.shu.qiu@intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).