From: Leonard Crestez <leonard.crestez@nxp.com>
To: "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
Abel Vesa <abel.vesa@nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"A.s. Dong" <aisheng.dong@nxp.com>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"abelvesa@linux.com" <abelvesa@linux.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"robh@kernel.org" <robh@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [PATCH v10 4/5] clk: imx: add imx composite clock
Date: Tue, 9 Oct 2018 22:56:14 +0000 [thread overview]
Message-ID: <5c0cc4de8403fca17431a9382f7e34e8003f497b.camel@nxp.com> (raw)
In-Reply-To: <1539074230-27277-5-git-send-email-abel.vesa@nxp.com>
On Tue, 2018-10-09 at 08:37 +0000, Abel Vesa wrote:
> +struct clk *imx_clk_composite_8m_flags(const char *name,
> + const char **parent_names,
> + int num_parents, void __iomem *reg,
> + unsigned long flags);
> +
> +#define __imx_clk_composite_8m(name, parent_names, reg, flags) \
> + imx_clk_composite_8m_flags(name, parent_names, \
> + ARRAY_SIZE(parent_names), reg, \
> + flags | CLK_SET_RATE_NO_REPARENT | CLK_OPS_PARENT_ENABLE)
> +
> +#define imx_clk_composite_8m(name, parent_names, reg) \
> + __imx_clk_composite_8m(name, parent_names, reg, 0)
> +
> +#define imx_clk_composite_8m_critical(name, parent_names, reg) \
> + __imx_clk_composite_8m(name, parent_names, reg, CLK_IS_CRITICAL)
Does anyone else think that the "8m" would be prettier next to imx
rather than as a suffix? Using imx8m_clk_composite* and
imx7ulp_clk_composite* makes more sense to me.
--
Regards,
Leonard
next prev parent reply other threads:[~2018-10-09 22:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 8:37 [PATCH v10 0/5] Add i.MX8MQ clock driver Abel Vesa
2018-10-09 8:37 ` [PATCH v10 1/5] dt-bindings: add binding for i.MX8MQ CCM Abel Vesa
2018-10-09 8:37 ` [PATCH v10 2/5] clk: imx: add fractional PLL output clock Abel Vesa
2018-10-09 8:37 ` [PATCH v10 3/5] clk: imx: add SCCG PLL type Abel Vesa
2018-10-09 8:37 ` [PATCH v10 4/5] clk: imx: add imx composite clock Abel Vesa
2018-10-09 22:56 ` Leonard Crestez [this message]
2018-10-10 5:37 ` Sascha Hauer
2018-10-10 7:50 ` Abel Vesa
2018-10-09 8:37 ` [PATCH v10 5/5] clk: imx: add clock driver for i.MX8MQ CCM Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c0cc4de8403fca17431a9382f7e34e8003f497b.camel@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=abel.vesa@nxp.com \
--cc=abelvesa@linux.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).