From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Victor Hassan <victor@allwinnertech.com>
Cc: marcel@holtmann.org, johan.hedberg@gmail.com,
luiz.dentz@gmail.com, linux-bluetooth@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND] Bluetooth: btrtl: Add support for RTL8852BS
Date: Mon, 6 Feb 2023 11:03:10 +0100 [thread overview]
Message-ID: <5c249a19-f79b-346d-2fb1-cdfc05324909@molgen.mpg.de> (raw)
In-Reply-To: <20230206063334.45861-1-victor@allwinnertech.com>
Dear Victor,
Thank you for your patch.
Am 06.02.23 um 07:33 schrieb Victor Hassan:
> Add the support for RTL8852BS BT controller on UART interface.
> The necessary firmware file will be submitted to linux-firmware.
>
> Signed-off-by: Victor Hassan <victor@allwinnertech.com>
> ---
> drivers/bluetooth/btrtl.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 69c3fe649ca7..36c3a23324f8 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -198,6 +198,14 @@ static const struct id_table ic_id_table[] = {
> .fw_name = "rtl_bt/rtl8852bu_fw.bin",
> .cfg_name = "rtl_bt/rtl8852bu_config" },
>
> + /* 8852B with UART interface */
> + { IC_INFO(RTL_ROM_LMP_8852A, 0xb, 0xb, HCI_UART),
> + .config_needed = true,
> + .has_rom_version = true,
> + .has_msft_ext = true,
> + .fw_name = "rtl_bt/rtl8852bs_fw.bin",
> + .cfg_name = "rtl_bt/rtl8852bs_config" },
> +
I’d sort *bs* before *bu*.
> /* 8852C */
> { IC_INFO(RTL_ROM_LMP_8852A, 0xc, 0xc, HCI_USB),
> .config_needed = false,
> @@ -965,5 +973,7 @@ MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin");
> MODULE_FIRMWARE("rtl_bt/rtl8852au_config.bin");
> MODULE_FIRMWARE("rtl_bt/rtl8852bu_fw.bin");
> MODULE_FIRMWARE("rtl_bt/rtl8852bu_config.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8852bs_fw.bin");
> +MODULE_FIRMWARE("rtl_bt/rtl8852bs_config.bin");
> MODULE_FIRMWARE("rtl_bt/rtl8852cu_fw.bin");
> MODULE_FIRMWARE("rtl_bt/rtl8852cu_config.bin");
Ditto.
Kind regards,
Paul
next prev parent reply other threads:[~2023-02-06 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 6:33 [RESEND] Bluetooth: btrtl: Add support for RTL8852BS Victor Hassan
2023-02-06 10:03 ` Paul Menzel [this message]
2023-02-14 6:23 ` Victor Hassan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c249a19-f79b-346d-2fb1-cdfc05324909@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=victor@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).