From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux@armlinux.org.uk, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] serial: amba-pl011: add RS485 support
Date: Tue, 29 Jun 2021 11:46:27 +0200 [thread overview]
Message-ID: <5c249dfc-90a6-7724-e884-9516aaf829fb@gmx.de> (raw)
In-Reply-To: <a89dec92-e764-c833-bbeb-ba3d84381e78@kernel.org>
Hi,
On 26.06.21 at 05:41, Jiri Slaby wrote:
> On 25. 06. 21, 13:21, Lino Sanfilippo wrote:
>> Thats right, the logic has slightly changed. I thought this does not matter as long as
>> we make sure that exactly one of both ON_SEND or AFTER_SEND is set.
>
> I actually don't know. But I would remain consistent with other drivers.
>
>> We can stick with the logic
>> in serial8250_em485_config() (i.e. always set ON_SEND and delete AFTER_SEND in case
>> of an invalid setting), but I think this will require more than the four lines that we
>> have now (especially if we want to avoid the !!).
>
> What if you used only a single !?
>
You are right, this is the easiest way to keep the current logic. I will do that.
Thanks,
Lino
prev parent reply other threads:[~2021-06-29 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 14:51 [PATCH v2] serial: amba-pl011: add RS485 support Lino Sanfilippo
2021-06-24 12:55 ` Greg KH
2021-06-25 0:15 ` Lino Sanfilippo
2021-06-25 6:01 ` Jiri Slaby
2021-06-25 11:21 ` Lino Sanfilippo
2021-06-26 3:41 ` Jiri Slaby
2021-06-29 9:46 ` Lino Sanfilippo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c249dfc-90a6-7724-e884-9516aaf829fb@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).