From: Dmitry Osipenko <digetx@gmail.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/16] NVIDIA Tegra devfreq improvements and Tegra20/30 support
Date: Wed, 5 Jun 2019 02:09:28 +0300 [thread overview]
Message-ID: <5c2a7c32-a98c-3930-14ae-beb0241908d0@gmail.com> (raw)
In-Reply-To: <683b343a-e64f-8345-ac44-10f5c00521bd@samsung.com>
04.06.2019 3:49, Chanwoo Choi пишет:
> On 19. 6. 4. 오전 1:52, Dmitry Osipenko wrote:
>> 03.05.2019 3:52, Dmitry Osipenko пишет:
>>> 03.05.2019 3:31, Chanwoo Choi пишет:
>>>> Hi Dmitry,
>>>>
>>>> On 19. 5. 2. 오전 8:37, Dmitry Osipenko wrote:
>>>>> Changelog:
>>>>>
>>>>> v4: Addressed all review comments that were made by Chanwoo Choi to v3:
>>>>>
>>>>> - changed the driver removal order to match the probe exactly
>>>>> - added clarifying comment for 1/8 ratio to the Tegra20 driver
>>>>>
>>>>> Chanwoo, please also note that the clk patch that should fix
>>>>> compilation problem that was reported the kbuild-test-robot is already
>>>>> applied and available in the recent linux-next.
>>>>
>>>> I knew that Stephen picked up your path about clock.
>>>
>>> Hi Chanwoo,
>>>
>>> Okay, good. Thank you very much for reviewing this series! I assume it's
>>> too late now for v5.2, but it should be good to go for v5.3.
>>>
>>
>> Hello Chanwoo,
>>
>> Will be nice to see the patches in the linux-next before they'll hit mainline. We have tested that
>> everything works fine on a selective devices, but won't hurt to get some extra testing beforehand.
>> AFAIK, at least NVIDIA people are regularly testing -next on theirs dev boards. Please note that
>> this not very important, so don't bother if there is some hurdle with pushing to the tracking branch
>> for now. Also please let me know if you're expecting to see some ACK's on the patches, I'm sure
>> we'll be able to work out that with Thierry and Jon if necessary.
>>
>>
>
> Hi Dmitry,
> I think that it is enough for applying to mainline branch.
> The devfreq.git is maintained by Myungjoo. He will be merged or
> reviewed if there are th remained review point.
Thank you very much!
>
> Hi Myungjoo,
> I reviewed the Dmitry's patches from v1 to v4 patches.
> And then I tested them on my testing branch[1] for catching
> the build warning and error. In result, it is clean.
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing
>
> Please review or apply these patches for v5.3.
>
Hello Myungjoo,
I think this patchset should be completed now. Thierry has some extra
comments to the patches, but seems nothing critical so far and all the
concerns could be addressed in a follow-up series. Please let me know if
you're fine with this, I can re-spin v5 as well if necessary.
next prev parent reply other threads:[~2019-06-04 23:09 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190501234148epcas5p1cc9a8dafa9ee6d8d046d1292b8270727@epcas5p1.samsung.com>
2019-05-01 23:37 ` [PATCH v4 00/16] NVIDIA Tegra devfreq improvements and Tegra20/30 support Dmitry Osipenko
2019-05-01 23:38 ` [PATCH v4 01/16] PM / devfreq: tegra: Fix kHz to Hz conversion Dmitry Osipenko
2019-06-04 10:54 ` Thierry Reding
2019-05-01 23:38 ` [PATCH v4 02/16] PM / devfreq: tegra: Replace readl-writel with relaxed versions Dmitry Osipenko
2019-06-04 10:55 ` Thierry Reding
2019-05-01 23:38 ` [PATCH v4 03/16] PM / devfreq: tegra: Replace write memory barrier with the read barrier Dmitry Osipenko
2019-06-04 10:56 ` Thierry Reding
2019-05-01 23:38 ` [PATCH v4 04/16] PM / devfreq: tegra: Don't ignore clk errors Dmitry Osipenko
2019-06-04 10:57 ` Thierry Reding
2019-05-01 23:38 ` [PATCH v4 05/16] PM / devfreq: tegra: Don't set EMC clock rate to maximum on probe Dmitry Osipenko
2019-06-04 11:00 ` Thierry Reding
2019-06-04 13:05 ` Dmitry Osipenko
2019-05-01 23:38 ` [PATCH v4 06/16] PM / devfreq: tegra: Drop primary interrupt handler Dmitry Osipenko
2019-06-04 11:02 ` Thierry Reding
2019-05-01 23:38 ` [PATCH v4 07/16] PM / devfreq: tegra: Properly disable interrupts Dmitry Osipenko
2019-06-04 11:07 ` Thierry Reding
2019-06-04 13:40 ` Dmitry Osipenko
2019-06-04 14:06 ` Thierry Reding
2019-06-04 14:59 ` Dmitry Osipenko
2019-06-04 22:55 ` Dmitry Osipenko
2019-06-07 16:58 ` Dmitry Osipenko
2019-05-01 23:38 ` [PATCH v4 08/16] PM / devfreq: tegra: Clean up driver's probe / remove Dmitry Osipenko
2019-06-04 11:09 ` Thierry Reding
2019-05-01 23:38 ` [PATCH v4 09/16] PM / devfreq: tegra: Avoid inconsistency of current frequency value Dmitry Osipenko
2019-06-04 11:14 ` Thierry Reding
2019-05-01 23:38 ` [PATCH v4 10/16] PM / devfreq: tegra: Mark ACTMON's governor as immutable Dmitry Osipenko
2019-06-04 11:15 ` Thierry Reding
2019-05-01 23:38 ` [PATCH v4 11/16] PM / devfreq: tegra: Move governor registration to driver's probe Dmitry Osipenko
2019-06-04 11:15 ` Thierry Reding
2019-05-01 23:38 ` [PATCH v4 12/16] PM / devfreq: tegra: Reconfigure hardware on governor's restart Dmitry Osipenko
2019-06-04 11:17 ` Thierry Reding
2019-05-01 23:38 ` [PATCH v4 13/16] PM / devfreq: tegra: Support Tegra30 Dmitry Osipenko
2019-06-04 11:18 ` Thierry Reding
2019-05-01 23:38 ` [PATCH v4 14/16] PM / devfreq: tegra: Enable COMPILE_TEST for the driver Dmitry Osipenko
2019-06-04 11:20 ` Thierry Reding
2019-06-04 13:53 ` Dmitry Osipenko
2019-06-04 14:10 ` Thierry Reding
2019-06-04 14:18 ` Thierry Reding
2019-06-04 14:41 ` Dmitry Osipenko
2019-06-04 14:50 ` Thierry Reding
2019-06-04 15:15 ` Dmitry Osipenko
2019-05-01 23:38 ` [PATCH v4 15/16] PM / devfreq: tegra: Rename tegra-devfreq.c to tegra30-devfreq.c Dmitry Osipenko
2019-06-04 11:23 ` Thierry Reding
2019-06-04 14:35 ` Dmitry Osipenko
2019-05-01 23:38 ` [PATCH v4 16/16] PM / devfreq: Introduce driver for NVIDIA Tegra20 Dmitry Osipenko
2019-06-04 11:25 ` Thierry Reding
2019-06-04 13:57 ` Dmitry Osipenko
2019-05-03 0:31 ` [PATCH v4 00/16] NVIDIA Tegra devfreq improvements and Tegra20/30 support Chanwoo Choi
2019-05-03 0:52 ` Dmitry Osipenko
2019-06-03 16:52 ` Dmitry Osipenko
2019-06-04 0:49 ` Chanwoo Choi
2019-06-04 23:09 ` Dmitry Osipenko [this message]
2019-06-23 17:17 ` Dmitry Osipenko
2019-06-23 23:50 ` Chanwoo Choi
2019-06-24 0:35 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c2a7c32-a98c-3930-14ae-beb0241908d0@gmail.com \
--to=digetx@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=jonathanh@nvidia.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).