From: Egil Hjelmeland <privat@egil-hjelmeland.no>
To: Andrew Lunn <andrew@lunn.ch>
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: dsa: lan9303: Clear offload_fwd_mark for IGMP
Date: Mon, 13 Nov 2017 14:04:24 +0100 [thread overview]
Message-ID: <5c43fc12-da9b-c5ae-d65c-c12be9337b84@egil-hjelmeland.no> (raw)
In-Reply-To: <20171113130227.GC22473@lunn.ch>
On 13. nov. 2017 14:02, Andrew Lunn wrote:
>> RTFM, my bad. The lan9303 has both STP and IGMP bits in the receive tag. It
>> is as simple as:
>>
>> u16 lan9303_tag1 = ntohs(lan9303_tag[1]);
>> skb->offload_fwd_mark = !(lan9303_tag1 & 0x18);
>
> Hi Egil
>
> That is much nicer. But please add a couple of #defines for the 0x18
> bits.
>
Of course!
> Andrew
>
Egil
next prev parent reply other threads:[~2017-11-13 13:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 11:54 [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling Egil Hjelmeland
2017-11-10 11:54 ` [PATCH net-next 1/2] net: dsa: lan9303: Set up trapping of IGMP to CPU port Egil Hjelmeland
2017-11-10 14:10 ` Andrew Lunn
2017-11-10 11:54 ` [PATCH net-next 2/2] net: dsa: lan9303: Clear offload_fwd_mark for IGMP Egil Hjelmeland
2017-11-13 11:00 ` Egil Hjelmeland
2017-11-13 13:02 ` Andrew Lunn
2017-11-13 13:04 ` Egil Hjelmeland [this message]
2017-11-10 14:07 ` [PATCH net-next 0/2] net: dsa: lan9303: IGMP handling Andrew Lunn
2017-11-10 18:22 ` Egil Hjelmeland
2017-11-11 12:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c43fc12-da9b-c5ae-d65c-c12be9337b84@egil-hjelmeland.no \
--to=privat@egil-hjelmeland.no \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).