From: "Thomas Müller" <thomas@mathtm.de>
To: peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: disabling secondary CPU hangs / system fails to suspend with kernel 4.19+
Date: Thu, 14 Mar 2019 16:17:28 +0100 [thread overview]
Message-ID: <5c48095e-028a-404f-aaa1-964f83c83817@mathtm.de> (raw)
Hi,
starting with kernel 4.19 my Lenovo ThinkPad X1 Carbon 5th no longer properly suspends.
This is 100% reproducible and git bisect points to the following commit:
> [be45bf5395e0886a93fc816bbe41a008ec2e42e2] watchdog/softlockup: Fix cpu_stop_queue_work() double-queue bug
> be45bf5395e0886a93fc816bbe41a008ec2e42e2 is the first bad commit
> commit be45bf5395e0886a93fc816bbe41a008ec2e42e2
> Author: Peter Zijlstra <peterz@infradead.org>
> Date: Fri Jul 13 12:42:08 2018 +0200
>
> watchdog/softlockup: Fix cpu_stop_queue_work() double-queue bug
>
> When scheduling is delayed for longer than the softlockup interrupt
> period it is possible to double-queue the cpu_stop_work, causing list
> corruption.
>
> Cure this by adding a completion to track the cpu_stop_work's
> progress.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Tested-by: Rong Chen <rong.a.chen@intel.com>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Fixes: 9cf57731b63e ("watchdog/softlockup: Replace "watchdog/%u" threads with cpu_stop_work")
> Link: http://lkml.kernel.org/r/20180713104208.GW2494@hirez.programming.kicks-ass.net
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
>
> :040000 040000 6aca2dbb84bc33fe442b18b3d0a135c27adff7b9 2710af12d32e4b98df07768716689b213bce45fc M kernel
The bugzilla reports have some additional details:
* https://bugzilla.redhat.com/show_bug.cgi?id=1671504
* https://bugzilla.kernel.org/show_bug.cgi?id=202679
* https://bugzilla.kernel.org/show_bug.cgi?id=202137
I'm happy to provide additional information or test a patch or two (as long as it doesn't
eat up my notebook ;))
Best regards
Thomas
next reply other threads:[~2019-03-14 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 15:17 Thomas Müller [this message]
2019-03-15 9:09 ` disabling secondary CPU hangs / system fails to suspend with kernel 4.19+ Peter Zijlstra
2019-03-15 11:41 ` Thomas Müller
2019-03-15 12:15 ` Peter Zijlstra
2019-03-15 20:21 ` Thomas Müller
2019-03-18 11:57 ` Peter Zijlstra
2019-03-29 9:22 ` Thomas Müller
2019-04-12 5:30 ` Thomas Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c48095e-028a-404f-aaa1-964f83c83817@mathtm.de \
--to=thomas@mathtm.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).