From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04F9EC47404 for ; Fri, 11 Oct 2019 13:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7AAC214AF for ; Fri, 11 Oct 2019 13:43:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728358AbfJKNnj (ORCPT ); Fri, 11 Oct 2019 09:43:39 -0400 Received: from imap1.codethink.co.uk ([176.9.8.82]:34083 "EHLO imap1.codethink.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727855AbfJKNnj (ORCPT ); Fri, 11 Oct 2019 09:43:39 -0400 Received: from [167.98.27.226] (helo=[10.35.5.173]) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1iIvCf-0005ik-SM; Fri, 11 Oct 2019 14:43:34 +0100 Subject: Re: [PATCH] proc: centralise declaration of cpuinfo_op To: Christoph Hellwig Cc: linux-kernel@lists.codethink.co.uk, Greg Kroah-Hartman , Mark Salter , Aurelien Jacquiot , Heiko Carstens , Yoshinori Sato , Rich Felker , "David S. Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, linux-c6x-dev@linux-c6x.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20191009113930.13236-1-ben.dooks@codethink.co.uk> <20191009175149.GA28540@infradead.org> From: Ben Dooks Organization: Codethink Limited. Message-ID: <5c4ad594-55a3-a9c5-1674-e85665422aa1@codethink.co.uk> Date: Fri, 11 Oct 2019 14:43:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191009175149.GA28540@infradead.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/2019 18:51, Christoph Hellwig wrote: > On Wed, Oct 09, 2019 at 12:39:30PM +0100, Ben Dooks wrote: >> When building for arm, cpuinfo_op generates a warning due >> to no declaration. Since this is used in fs/proc/cpuinfo.c >> and inconsitently declared across archiectures move the >> declaration info . This means that the >> cpuinfo_op will have a declaration any place it is used. >> >> Removes the following sparse warning: >> >> arch/arm/kernel/setup.c:1320:29: warning: symbol 'cpuinfo_op' was not declared. Should it be static? > > I like the consolidation, but I don't think seq_file.h is the right > place. A procfs or cpu topology related header seems like the better > choice. Ok, thanks. I'll have a look at where else it could go, but I'm not sure if I have the resources to build /all/ kernels that this would effect. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html