From: Alex Shi <alex.shi@linux.alibaba.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Russell King <linux@armlinux.org.uk>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/3] mm/armv6: work around armv6 cmpxchg support issue
Date: Thu, 3 Sep 2020 14:47:13 +0800 [thread overview]
Message-ID: <5c6020c8-2fdd-13ef-0e83-bea3b32364af@linux.alibaba.com> (raw)
In-Reply-To: <20200901131749.GL14765@casper.infradead.org>
在 2020/9/1 下午9:17, Matthew Wilcox 写道:
> On Tue, Sep 01, 2020 at 02:30:51PM +0800, Alex Shi wrote:
>> seems there are couples archs can not do cmpxchg1
>> So update the patch here. And it's easy to fix if more arch issue find here.
>
>> +/*
>> + * cmpxchg only support 32-bits operands on the following archs ARMv6, SPARC32
>> + * sh2, XTENSA.
>> + */
>> +#if defined(CONFIG_CPU_V6) || defined(CONFIG_CPU_SH2) || \
>> + defined(CONFIG_SPARC32) || defined(CONFIG_XTENSA)
>
> Looks like we need a HAVE_CMPXCHG_BYTE in Kconfig to parallel
> HAVE_CMPXCHG_DOUBLE.
>
Thanks for reminder! Compare the HAVE_CMPXCHG_BYTE, NO_CMPXCHG_BYTE would be
better for less code change.
I will send the v4 for a bit more change on patch 2.
Thanks!
Alex
next prev parent reply other threads:[~2020-09-03 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 2:50 [PATCH v3 1/3] mm/pageblock: mitigation cmpxchg false sharing in pageblock flags Alex Shi
2020-09-01 2:50 ` [PATCH v3 2/3] mm/pageblock: remove false sharing in pageblock_flags Alex Shi
2020-09-01 2:50 ` [PATCH v3 3/3] mm/armv6: work around armv6 cmpxchg support issue Alex Shi
2020-09-01 6:30 ` Alex Shi
2020-09-01 13:17 ` Matthew Wilcox
2020-09-03 6:47 ` Alex Shi [this message]
2020-09-01 17:06 ` [PATCH v3 1/3] mm/pageblock: mitigation cmpxchg false sharing in pageblock flags Vlastimil Babka
2020-09-03 6:42 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c6020c8-2fdd-13ef-0e83-bea3b32364af@linux.alibaba.com \
--to=alex.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@armlinux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).