From: Martin Schiller <ms@dev.tdt.de>
To: Xie He <xie.he.0141@gmail.com>
Cc: andrew.hendry@gmail.com, davem@davemloft.net, kuba@kernel.org,
linux-x25@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6 2/5] net/lapb: support netdev events
Date: Thu, 26 Nov 2020 07:14:24 +0100 [thread overview]
Message-ID: <5c74d51e4cd3ee0aae47c84988dbbf91@dev.tdt.de> (raw)
In-Reply-To: <20201126000814.12108-1-xie.he.0141@gmail.com>
On 2020-11-26 01:08, Xie He wrote:
> Hi Martin,
>
> Since we are going to assume lapb->state would remain in LAPB_STATE_0
> when
> the carrier is down (as understood by me. Right?), could we add a check
> in
> lapb_connect_request to reject the upper layer's "connect" instruction
> when
> the carrier is down? Like this:
No, because this will break the considered "on demand" calling feature.
>
> diff --git a/include/linux/lapb.h b/include/linux/lapb.h
> index eb56472f23b2..7923b1c6fc6a 100644
> --- a/include/linux/lapb.h
> +++ b/include/linux/lapb.h
> @@ -14,6 +14,7 @@
> #define LAPB_REFUSED 5
> #define LAPB_TIMEDOUT 6
> #define LAPB_NOMEM 7
> +#define LAPB_NOCARRIER 8
>
> #define LAPB_STANDARD 0x00
> #define LAPB_EXTENDED 0x01
> diff --git a/net/lapb/lapb_iface.c b/net/lapb/lapb_iface.c
> index 3c03f6512c5f..c909d8db1bef 100644
> --- a/net/lapb/lapb_iface.c
> +++ b/net/lapb/lapb_iface.c
> @@ -270,6 +270,10 @@ int lapb_connect_request(struct net_device *dev)
> if (!lapb)
> goto out;
>
> + rc = LAPB_NOCARRIER;
> + if (!netif_carrier_ok(dev))
> + goto out_put;
> +
> rc = LAPB_OK;
> if (lapb->state == LAPB_STATE_1)
> goto out_put;
>
> Also, since we are going to assume the lapb->state would remain in
> LAPB_STATE_0 when the carrier is down, are the
> "lapb->state == LAPB_STATE_0" checks in carrier-up/device-up event
> handling necessary? If they are not necessary, it might be better to
> remove them because it may confuse people reading the code.
They are still necessary, because if the link setup is initiated by
upper layers, we've already entered the respective state by
lapb_connect_request().
Every suggestion for improvement is really welcome, but please let this
patch set pass now, if you don't find any more gross errors.
Martin
next prev parent reply other threads:[~2020-11-26 6:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 9:39 [PATCH net-next v6 0/5] net/x25: netdev event handling Martin Schiller
2020-11-24 9:39 ` [PATCH net-next v6 1/5] net/x25: handle additional netdev events Martin Schiller
2020-11-24 9:39 ` [PATCH net-next v6 2/5] net/lapb: support " Martin Schiller
2020-11-24 19:05 ` Xie He
2020-11-25 21:49 ` Jakub Kicinski
2020-11-26 5:57 ` Martin Schiller
2020-11-26 0:08 ` Xie He
2020-11-26 6:14 ` Martin Schiller [this message]
2020-11-24 9:39 ` [PATCH net-next v6 3/5] net/lapb: fix t1 timer handling for LAPB_STATE_0 Martin Schiller
2020-11-24 9:39 ` [PATCH net-next v6 4/5] net/x25: fix restart request/confirm handling Martin Schiller
2020-11-24 9:39 ` [PATCH net-next v6 5/5] net/x25: remove x25_kill_by_device() Martin Schiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c74d51e4cd3ee0aae47c84988dbbf91@dev.tdt.de \
--to=ms@dev.tdt.de \
--cc=andrew.hendry@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).