From: Hans Verkuil <hverkuil@xs4all.nl>
To: Arnd Bergmann <arnd@arndb.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, y2038@lists.linaro.org
Subject: Re: [PATCH v4 0/8] y2038 safety in v4l2
Date: Mon, 25 Nov 2019 17:02:41 +0100 [thread overview]
Message-ID: <5c7bed6e-12d9-15e0-236e-d4f99710fbbd@xs4all.nl> (raw)
In-Reply-To: <20191111203835.2260382-1-arnd@arndb.de>
Hi Arnd,
On 11/11/19 9:38 PM, Arnd Bergmann wrote:
> I'm in the process of finishing up the last bits on y2038-unsafe
> code in the kernel, this series is for v4l2, which has no problem
> with overflow, but has multiple ioctls that break with user space
> built against a new 32-bit libc.
Thank you for working on this. Much appreciated!
I've reviewed this v4 series and found a few issues (mostly things
that ended up in videodev2.h that shouldn't be there).
Once a v5 is posted I'll try to test this more.
Is there an easy(-ish) way to test this with a time64 ABI? Do you
have such an environment set up for testing?
>
> I posted similar patches as part of a series back in 2015, the
> new version was rewritten from scratch and I double-checked with
> the old version to make sure I did not miss anything I had already
> taken care of before.
>
> Hans Verkuil worked on a different patch set in 2017, but this
> also did not get to the point of being merged.
>
> My new version contains compat-ioctl support, which the old one
> did not and should be complete, but given its size likely contains
> bugs. I did randconfig build tests, but no runtime test, so
> careful review as well as testing would be much appreciated.
>
> With this version, the newly added code takes care of the existing
> ABI, while the existing code got moved to the 64-bit time_t
> interface and is used internally. This means that testing with
> existing binaries should exercise most of the modifications
> and if that works and doesn't get shot down in review, we can
> probably live without testing the new ABI explicitly.
>
> I'm not entirely happy with the compat-ioctl implementation that
> adds quite a bit of code duplication, but I hope this is
> acceptable anyway, as a better implementation would likely
> require a larger refactoring of the compat-ioctl file, while
> my approach simply adds support for the additional data structure
> variants.
A cleanup is indeed much more work. This y2038 code is awful, but that's
really because the original structs are aligned in the worst possible
way.
Regards,
Hans
>
> This is a minor update compared to version 3 of this series,
> with bugfixes for small mistakes that I found or that were
> reported by automated build bots. I updated the tree at [2]
> to this version now.
>
> Arnd
>
> [1] https://lwn.net/Articles/657754/
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/log/?h=y2038-v4l2
>
> Arnd Bergmann (8):
> media: documentation: fix video_event description
> media: v4l2: abstract timeval handling in v4l2_buffer
> media: v4l2-core: compat: ignore native command codes
> media: v4l2-core: split out data copy from video_usercopy
> media: v4l2-core: fix VIDIOC_DQEVENT for time64 ABI
> media: v4l2-core: fix v4l2_buffer handling for time64 ABI
> media: v4l2-core: fix compat VIDIOC_DQEVENT for time64 ABI
> media: v4l2-core: fix compat v4l2_buffer handling for time64 ABI
>
> .../media/uapi/dvb/video-get-event.rst | 2 +-
> Documentation/media/uapi/dvb/video_types.rst | 2 +-
> .../media/common/videobuf2/videobuf2-v4l2.c | 4 +-
> drivers/media/pci/meye/meye.c | 4 +-
> drivers/media/usb/cpia2/cpia2_v4l.c | 4 +-
> drivers/media/usb/stkwebcam/stk-webcam.c | 2 +-
> drivers/media/usb/usbvision/usbvision-video.c | 4 +-
> drivers/media/v4l2-core/v4l2-compat-ioctl32.c | 470 +++++++++++++++---
> drivers/media/v4l2-core/v4l2-event.c | 5 +-
> drivers/media/v4l2-core/v4l2-ioctl.c | 188 +++++--
> drivers/media/v4l2-core/v4l2-subdev.c | 20 +-
> drivers/media/v4l2-core/videobuf-core.c | 4 +-
> include/linux/videodev2.h | 17 +-
> include/trace/events/v4l2.h | 2 +-
> include/uapi/linux/videodev2.h | 77 +++
> 15 files changed, 669 insertions(+), 136 deletions(-)
>
next prev parent reply other threads:[~2019-11-25 16:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 20:38 [PATCH v4 0/8] y2038 safety in v4l2 Arnd Bergmann
2019-11-11 20:38 ` [PATCH v4 1/8] media: documentation: fix video_event description Arnd Bergmann
2019-11-11 20:38 ` [PATCH v4 2/8] media: v4l2: abstract timeval handling in v4l2_buffer Arnd Bergmann
2019-11-25 15:52 ` Hans Verkuil
2019-11-26 11:34 ` Arnd Bergmann
2019-11-26 11:43 ` Hans Verkuil
2019-11-26 12:42 ` Arnd Bergmann
2019-11-11 20:38 ` [PATCH v4 3/8] media: v4l2-core: compat: ignore native command codes Arnd Bergmann
[not found] ` <20191122070015.D5A702068E@mail.kernel.org>
2019-11-22 12:29 ` Arnd Bergmann
2019-11-11 20:38 ` [PATCH v4 4/8] media: v4l2-core: split out data copy from video_usercopy Arnd Bergmann
2019-11-11 20:38 ` [PATCH v4 5/8] media: v4l2-core: fix VIDIOC_DQEVENT for time64 ABI Arnd Bergmann
2019-11-25 14:40 ` Hans Verkuil
2019-11-26 14:43 ` Arnd Bergmann
2019-11-26 15:10 ` Hans Verkuil
2019-11-26 15:19 ` Arnd Bergmann
2019-11-11 20:38 ` [PATCH v4 6/8] media: v4l2-core: fix v4l2_buffer handling " Arnd Bergmann
2019-11-25 14:57 ` Hans Verkuil
2019-11-26 13:50 ` Arnd Bergmann
2019-11-26 14:15 ` Hans Verkuil
2019-11-26 15:17 ` Arnd Bergmann
2019-11-26 15:24 ` Hans Verkuil
2019-11-11 20:38 ` [PATCH v4 7/8] media: v4l2-core: fix compat VIDIOC_DQEVENT " Arnd Bergmann
2019-11-11 20:38 ` [PATCH v4 8/8] media: v4l2-core: fix compat v4l2_buffer handling " Arnd Bergmann
2019-11-25 16:02 ` Hans Verkuil [this message]
2019-11-26 11:13 ` [PATCH v4 0/8] y2038 safety in v4l2 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c7bed6e-12d9-15e0-236e-d4f99710fbbd@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).