From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: thierry.reding@gmail.com, lee.jones@linaro.org,
nsaenzjulienne@suse.de, f.fainelli@gmail.com, rjui@broadcom.com,
sbranden@broadcom.com, bcm-kernel-feedback-list@broadcom.com,
linux-pwm@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, sean@mess.org
Subject: Re: [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration
Date: Sat, 5 Dec 2020 00:25:41 +0100 [thread overview]
Message-ID: <5c7c96ff-5323-2dd9-b56d-57a10b6576f2@gmx.de> (raw)
In-Reply-To: <20201204112115.wopx5p5elgte7gad@pengutronix.de>
Hi,
On 04.12.20 at 12:21, Uwe Kleine-König wrote:
>
> I'd make value an unsigned long long and check for > 0xffffffff instead
> of repeating the (expensive) division. (Hmm, maybe the compiler is smart
> enough to not actually repeat it, but still.)
I also prefer unsigned long long over u64 since thats what DIV_ROUND_CLOSEST_ULL returns.
However since we have the constant U32_MAX for 0xffffffff we should use that.
Thanks,
Lino
prev parent reply other threads:[~2020-12-04 23:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202011281128.54eLfMWr-lkp@intel.com>
2020-11-28 12:02 ` [PATCH v2] pwm: bcm2835: Support apply function for atomic configuration Lino Sanfilippo
2020-11-29 18:10 ` Uwe Kleine-König
2020-12-03 23:42 ` Lino Sanfilippo
2020-12-04 8:44 ` Sean Young
2020-12-04 8:58 ` Sean Young
2020-12-04 11:13 ` Uwe Kleine-König
2020-12-04 11:38 ` Sean Young
2020-12-04 23:28 ` Uwe Kleine-König
2020-12-05 17:34 ` Sean Young
2020-12-05 19:25 ` Uwe Kleine-König
2020-12-06 14:19 ` Sean Young
2020-12-07 8:16 ` Uwe Kleine-König
2020-12-07 9:43 ` Sean Young
2020-12-07 13:52 ` Uwe Kleine-König
2020-12-07 15:29 ` Thierry Reding
2020-12-07 21:46 ` Uwe Kleine-König
2020-12-07 18:18 ` Sean Young
2020-12-08 0:00 ` Lino Sanfilippo
2020-12-08 9:07 ` Uwe Kleine-König
2020-12-04 23:16 ` Lino Sanfilippo
2020-12-04 11:21 ` Uwe Kleine-König
2020-12-04 11:40 ` Sean Young
2020-12-04 21:55 ` Uwe Kleine-König
2020-12-04 22:44 ` Sean Young
2020-12-04 23:25 ` Lino Sanfilippo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c7c96ff-5323-2dd9-b56d-57a10b6576f2@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=sean@mess.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).