From: Dan Murphy <dmurphy@ti.com>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: <lee.jones@linaro.org>, <daniel.thompson@linaro.org>,
<jingoohan1@gmail.com>, <jacek.anaszewski@gmail.com>,
<pavel@ucw.cz>, <robh+dt@kernel.org>, <mark.rutland@arm.com>,
<b.zolnierkie@samsung.com>, <dri-devel@lists.freedesktop.org>,
<linux-leds@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-fbdev@vger.kernel.org>,
"H. Nikolaus Schaller" <hns@goldelico.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: backlight: lm3630a: add enable_gpios
Date: Thu, 12 Sep 2019 10:03:12 -0500 [thread overview]
Message-ID: <5c8d25ab-e780-4e60-9723-cd65553f4db3@ti.com> (raw)
In-Reply-To: <20190912165808.3c38b7a2@kemnade.info>
Andreas
On 9/12/19 9:58 AM, Andreas Kemnade wrote:
> On Thu, 12 Sep 2019 06:39:50 -0500
> Dan Murphy <dmurphy@ti.com> wrote:
>
>> Andreas
>>
>> On 9/11/19 12:21 PM, Andreas Kemnade wrote:
>>> add enable-gpios to describe HWEN pin
>>>
>>> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
>>> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
>>> ---
>>> changes in v2: added example
>>> changes in v3: added Acked-by
>>> .../bindings/leds/backlight/lm3630a-backlight.yaml | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>>> index dc129d9a329e..1fa83feffe16 100644
>>> --- a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>>> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>>> @@ -29,6 +29,10 @@ properties:
>>> '#size-cells':
>>> const: 0
>>>
>>> + enable-gpios:
>>> + description: GPIO to use to enable/disable the backlight (HWEN pin).
>>> + maxItems: 1
>>> +
>>> required:
>>> - compatible
>>> - reg
>>> @@ -92,6 +96,7 @@ examples:
>>> i2c {
>>> #address-cells = <1>;
>>> #size-cells = <0>;
>>> + enable-gpios = <&gpio2 5 GPIO_ACTIVE_HIGH>;
>>>
>>> led-controller@38 {
>>> compatible = "ti,lm3630a";
>> Looks good to me
>>
> well, the enable-gpios is still at the same place as in v2. This was sent
> before your comments to v2 have been arrived.
Ah I overlooked that. Yeah that still needs to move I assumed you moved it.
Dan
> Regards,
> Andreas
next prev parent reply other threads:[~2019-09-12 15:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 17:21 [PATCH v3 0/2] backlight_lm3630a: add enable_gpios property Andreas Kemnade
2019-09-11 17:21 ` [PATCH v3 1/2] dt-bindings: backlight: lm3630a: add enable_gpios Andreas Kemnade
2019-09-12 11:39 ` Dan Murphy
2019-09-12 14:58 ` Andreas Kemnade
2019-09-12 15:03 ` Dan Murphy [this message]
2019-09-11 17:21 ` [PATCH v3 2/2] backlight: lm3630a: add an enable gpio for the HWEN pin Andreas Kemnade
2019-09-12 9:38 ` Daniel Thompson
2019-09-12 11:40 ` Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c8d25ab-e780-4e60-9723-cd65553f4db3@ti.com \
--to=dmurphy@ti.com \
--cc=andreas@kemnade.info \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).