From: Zhi Wang <zhi.wang.linux@gmail.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Christoph Hellwig <hch@lst.de>,
"Wang, Zhi A" <zhi.a.wang@intel.com>
Cc: "jgg@nvidia.com" <jgg@nvidia.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
"Xu, Terrence" <terrence.xu@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API
Date: Mon, 7 Feb 2022 06:57:13 -0500 [thread overview]
Message-ID: <5c916187-8a8c-323a-adb4-8bce141180cc@gmail.com> (raw)
In-Reply-To: <877da7rlzr.fsf@intel.com>
On 2/7/22 05:48, Jani Nikula wrote:
> On Mon, 07 Feb 2022, Christoph Hellwig <hch@lst.de> wrote:
>> On Mon, Feb 07, 2022 at 08:28:13AM +0000, Wang, Zhi A wrote:
>>> 1) About having the mmio_table.h, I would like to keep the stuff in a
>>> dedicated header as putting them in intel_gvt.h might needs i915 guys
>>> to maintain it.
>>> 2) The other one is about if we should move the mmio_table.c into
>>> i915 folder. I guess we need the some comments from Jani. In the
>>> current version that I am testing, it's still in GVT folder. Guess we
>>> can submit a patch to move it to i915 folder later if Jani is ok
>>> about that.
>> Yes, let's have Jani chime in on these. They're basically one and the
>> same issue. This code will have to be built into into the core i915
>> driver even with my planned split, which is kindof the point of this
>> exercise. I think it makes sense to use the subdirectories as boundaries
>> for where the code ends up and not to declarare maintainership boundaries,
>> but it will be up to the i915 and gvt maintainers to decide that.
> Agreed. If there's going to be a gvt.ko, I think all of gvt/ should be
> part of that module, nothing more, nothing less.
>
> The gvt related files in i915/ should probably be named intel_gvt* or
> something, ditto for function naming, and we'll probably want patches
> touching them be Cc'd to intel-gfx list.
>
> Joonas, Rodrigo, Tvrtko, thoughts?
>
> BR,
> Jani.
Hi Christoph and Jani:
Thanks for the comments. It would be nice that people can achieve a
agreement. I am OK with both of the options and also moving some files
into different folders doesn't needs me to do the full test run again. :)
Thanks,
Zhi.
next prev parent reply other threads:[~2022-02-07 12:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 12:05 [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API Zhi Wang
2022-01-27 12:05 ` [PATCH 2/3] i915/gvt: save the initial HW state snapshot in i915 Zhi Wang
2022-01-31 6:38 ` Christoph Hellwig
2022-01-27 12:05 ` [PATCH 3/3] i915/gvt: Use the initial HW state snapshot saved " Zhi Wang
2022-01-27 14:52 ` [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API Christoph Hellwig
2022-01-27 17:14 ` [Intel-gfx] " kernel test robot
2022-01-27 17:46 ` kernel test robot
2022-01-27 19:08 ` kernel test robot
2022-01-28 5:01 ` [RFC PATCH] i915/gvt: intel_gvt_match_device() can be static kernel test robot
2022-01-28 5:11 ` [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API kernel test robot
2022-01-31 6:34 ` Christoph Hellwig
2022-02-07 7:32 ` Christoph Hellwig
2022-02-07 8:28 ` Wang, Zhi A
2022-02-07 8:35 ` Christoph Hellwig
2022-02-07 10:48 ` Jani Nikula
2022-02-07 11:57 ` Zhi Wang [this message]
2022-02-07 12:06 ` Christoph Hellwig
2022-02-07 12:13 ` Jani Nikula
2022-02-08 8:04 ` Joonas Lahtinen
2022-02-07 14:47 ` [Intel-gfx] " kernel test robot
2022-02-08 14:38 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c916187-8a8c-323a-adb4-8bce141180cc@gmail.com \
--to=zhi.wang.linux@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=terrence.xu@intel.com \
--cc=tvrtko.ursulin@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).