From: Alex Shi <alex.shi@linux.alibaba.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/cputime: remove irqtime_account_idle_ticks
Date: Thu, 16 Jan 2020 11:44:28 +0800 [thread overview]
Message-ID: <5c95e93d-c44c-b19e-62c0-b7c45c60e9e0@linux.alibaba.com> (raw)
In-Reply-To: <1579144650-161327-1-git-send-email-alex.shi@linux.alibaba.com>
在 2020/1/16 上午11:17, Alex Shi 写道:
> irqtime_account_idle_ticks just add longer call path w/o enough meaning.
> We don't bother remove this function to simply code and reduce a
> bit object size of kernel.
Sorry, above commit log need to revise as following:
irqtime_account_idle_ticks just add longer call path w/o enough meaning.
We'd better to remove this function to simply code and reduce a bit object
size of kernel.
>
> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Juri Lelli <juri.lelli@redhat.com>
> Cc: Vincent Guittot <vincent.guittot@linaro.org>
> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ben Segall <bsegall@google.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: linux-kernel@vger.kernel.org
> ---
> kernel/sched/cputime.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
> index cff3e656566d..17640d145e44 100644
> --- a/kernel/sched/cputime.c
> +++ b/kernel/sched/cputime.c
> @@ -390,12 +390,7 @@ static void irqtime_account_process_tick(struct task_struct *p, int user_tick,
> }
> }
>
> -static void irqtime_account_idle_ticks(int ticks)
> -{
> - irqtime_account_process_tick(current, 0, ticks);
> -}
> #else /* CONFIG_IRQ_TIME_ACCOUNTING */
> -static inline void irqtime_account_idle_ticks(int ticks) { }
> static inline void irqtime_account_process_tick(struct task_struct *p, int user_tick,
> int nr_ticks) { }
> #endif /* CONFIG_IRQ_TIME_ACCOUNTING */
> @@ -505,7 +500,7 @@ void account_idle_ticks(unsigned long ticks)
> u64 cputime, steal;
>
> if (sched_clock_irqtime) {
> - irqtime_account_idle_ticks(ticks);
> + irqtime_account_process_tick(current, 0, ticks);
> return;
> }
>
>
next prev parent reply other threads:[~2020-01-16 3:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 3:17 [PATCH] sched/cputime: remove irqtime_account_idle_ticks Alex Shi
2020-01-16 3:44 ` Alex Shi [this message]
[not found] ` <20200118003207.GA4067@geo.homenetwork>
[not found] ` <a9c6fa27-e0e3-7559-949d-93fcc1c0a1bb@linux.alibaba.com>
2020-01-18 3:09 ` Tao Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c95e93d-c44c-b19e-62c0-b7c45c60e9e0@linux.alibaba.com \
--to=alex.shi@linux.alibaba.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).