From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A131C05027 for ; Thu, 26 Jan 2023 22:26:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232905AbjAZW0v (ORCPT ); Thu, 26 Jan 2023 17:26:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbjAZW0t (ORCPT ); Thu, 26 Jan 2023 17:26:49 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 225324DCDE for ; Thu, 26 Jan 2023 14:25:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674771954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HklvufQZfBWJQ24G/LaO8a1AhEjWrY545//BpSv4N9I=; b=GBux802Ko/zPFi6LR08sMAZoPbm0ziOBWAJGwPZzm5DQpFEzSRJUKAuIdfJ/VI/CnGhBKB jLW1dc2MslSUQ5e3nmJ0lq8RRamWBHEqyuH94Sdkiyn3CcHcKWMi5j5GQSmJe5MgPh/NQD JBZXFpmivKdVB82CI3ERHrR3JKSp7lk= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-86-NkFDkkY6Ohqi3k6bQQ_LDQ-1; Thu, 26 Jan 2023 17:25:53 -0500 X-MC-Unique: NkFDkkY6Ohqi3k6bQQ_LDQ-1 Received: by mail-ed1-f72.google.com with SMTP id h18-20020a05640250d200b0049e0e9382c2so2312081edb.13 for ; Thu, 26 Jan 2023 14:25:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HklvufQZfBWJQ24G/LaO8a1AhEjWrY545//BpSv4N9I=; b=z+0Bid3vXjjlpEfmHIsErHIpw49RFCzts/p7St2ULU67d4tTKrAfjHDtwxWmx+syzT gSGf5OsZiNFU+VNj1+o3Hr1E8RS3PNjXy6BzZhFUICxSIeC8xmXY0OL4IQEMTjNXZC4z rXnHVOZqwzJC3AbfsSd4n2j/40MS4vtCpq2kXvnNnIJkTnLyMvojQByohWLXzfaZ5EjX UetXUE36Iv9p6GSrm5Pwc3NiuVJp0CzurjjafQATxJcnjN5Q8VXPns5NgP4MFoDF6ruf HnwLIzeDcPiBLgARXlkmq7ISO+g8MKhk7pIX778pA5Tsqp/obt4bM3bKY82KfjNj5JRZ k1yg== X-Gm-Message-State: AFqh2kr6g/NBJ0QfBmucDBg+SrdUSYSSqYaYMhNLpaMPnWd7JxOU/Csc TSlBB4WHBmc24ljpSufFZ7PThh/Q6HV35OcpHQTCXvZ5KVRX8sSIb1Wwcl+Gb716eRxmqbdMhua f7Tt74kaVddzBavYZ80oS7/Ko X-Received: by 2002:a17:907:8999:b0:877:83ea:2bfc with SMTP id rr25-20020a170907899900b0087783ea2bfcmr29298596ejc.39.1674771951250; Thu, 26 Jan 2023 14:25:51 -0800 (PST) X-Google-Smtp-Source: AMrXdXu8weu5499CBW7EQXZLSCEzQQ9uDVPguSl7RkTew9/qlc9qQ7QRBuzQoH7Teg0s42R+asqjQg== X-Received: by 2002:a17:907:8999:b0:877:83ea:2bfc with SMTP id rr25-20020a170907899900b0087783ea2bfcmr29298582ejc.39.1674771951068; Thu, 26 Jan 2023 14:25:51 -0800 (PST) Received: from ?IPV6:2a02:810d:4b3f:de78:642:1aff:fe31:a15c? ([2a02:810d:4b3f:de78:642:1aff:fe31:a15c]) by smtp.gmail.com with ESMTPSA id e14-20020a1709062c0e00b007c0a7286ac8sm1193875ejh.69.2023.01.26.14.25.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 14:25:50 -0800 (PST) Message-ID: <5caf64b6-0e3c-4c24-4fe8-9ed2caf43822@redhat.com> Date: Thu, 26 Jan 2023 23:25:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH] dma-buf: actually set signaling bit for private sub fences Content-Language: en-US To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Arvind.Yadav@amd.com, sumit.semwal@linaro.org, gustavo@padovan.org Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230126002844.339593-1-dakr@redhat.com> <4b13c48e-1677-3947-42e5-5ba241bcb96a@amd.com> From: Danilo Krummrich Organization: RedHat In-Reply-To: <4b13c48e-1677-3947-42e5-5ba241bcb96a@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/26/23 07:58, Christian König wrote: > Am 26.01.23 um 01:28 schrieb Danilo Krummrich: >> In dma_fence_allocate_private_stub() set the signaling bit of the newly >> allocated private stub fence rather than the signaling bit of the >> shared dma_fence_stub. >> >> Fixes: c85d00d4fd8b ("dma-buf: set signaling bit for the stub fence") >> Signed-off-by: Danilo Krummrich > > Good catch, Reviewed-by: Christian König > > Should I push it upstream as well or do you have commit access? Thanks, I can push it to drm-misc-next. > >> --- >>   drivers/dma-buf/dma-fence.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c >> index 406b4e26f538..0de0482cd36e 100644 >> --- a/drivers/dma-buf/dma-fence.c >> +++ b/drivers/dma-buf/dma-fence.c >> @@ -167,7 +167,7 @@ struct dma_fence >> *dma_fence_allocate_private_stub(void) >>                  0, 0); >>       set_bit(DMA_FENCE_FLAG_ENABLE_SIGNAL_BIT, >> -        &dma_fence_stub.flags); >> +        &fence->flags); >>       dma_fence_signal(fence); >