From: Chao Yu <chao@kernel.org>
To: Yangtao Li <frank.li@vivo.com>, jaegeuk@kernel.org
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] f2fs: cleanup in f2fs_create_flush_cmd_control()
Date: Tue, 25 Oct 2022 15:58:37 +0800 [thread overview]
Message-ID: <5cc0d3cd-8b32-0a05-f662-e2ec4f784900@kernel.org> (raw)
In-Reply-To: <20221025075623.7958-1-frank.li@vivo.com>
On 2022/10/25 15:56, Yangtao Li wrote:
> Remove the local 'err' variable for readable,
> no functional changes.
>
> Signed-off-by: Yangtao Li <frank.li@vivo.com>
> ---
> fs/f2fs/segment.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index acf3d3fa4363..ed247195a20c 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -620,12 +620,11 @@ int f2fs_create_flush_cmd_control(struct f2fs_sb_info *sbi)
> {
> dev_t dev = sbi->sb->s_bdev->bd_dev;
> struct flush_cmd_control *fcc;
> - int err = 0;
>
> if (SM_I(sbi)->fcc_info) {
> fcc = SM_I(sbi)->fcc_info;
> if (fcc->f2fs_issue_flush)
> - return err;
> + return 0;
> goto init_thread;
> }
>
> @@ -638,19 +637,18 @@ int f2fs_create_flush_cmd_control(struct f2fs_sb_info *sbi)
> init_llist_head(&fcc->issue_list);
> SM_I(sbi)->fcc_info = fcc;
> if (!test_opt(sbi, FLUSH_MERGE))
> - return err;
> + return 0;
>
> init_thread:
> fcc->f2fs_issue_flush = kthread_run(issue_flush_thread, sbi,
> "f2fs_flush-%u:%u", MAJOR(dev), MINOR(dev));
> if (IS_ERR(fcc->f2fs_issue_flush)) {
> - err = PTR_ERR(fcc->f2fs_issue_flush);
> kfree(fcc);
> SM_I(sbi)->fcc_info = NULL;
> - return err;
> + return PTR_ERR(fcc->f2fs_issue_flush);
It will cause use-after-free issue.
Thanks,
> }
>
> - return err;
> + return 0;
> }
>
> void f2fs_destroy_flush_cmd_control(struct f2fs_sb_info *sbi, bool free)
prev parent reply other threads:[~2022-10-25 7:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 7:56 [PATCH v2] f2fs: cleanup in f2fs_create_flush_cmd_control() Yangtao Li
2022-10-25 7:58 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cc0d3cd-8b32-0a05-f662-e2ec4f784900@kernel.org \
--to=chao@kernel.org \
--cc=frank.li@vivo.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).