From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049AbeECGla (ORCPT ); Thu, 3 May 2018 02:41:30 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:49291 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbeECGl1 (ORCPT ); Thu, 3 May 2018 02:41:27 -0400 From: "Reizer, Eyal" To: Tony Lindgren , Eyal Reizer CC: "bcousson@baylibre.com" , "robh+dt@kernel.org" , "mark.rutland@arm.com" , "linux-omap@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [EXTERNAL] Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support Thread-Topic: [EXTERNAL] Re: [PATCH] arm: dts: am437x-sk-evm: add wilink8 support Thread-Index: AQHT4iT/7H0+EMEe30+rXGHYgl+MB6QdiDjA Date: Thu, 3 May 2018 06:41:19 +0000 Message-ID: <5cc906da15da45ab96e06957f878b65b@ti.com> References: <1525159453-32489-1-git-send-email-eyalr@ti.com> <20180502145100.GK98604@atomide.com> In-Reply-To: <20180502145100.GK98604@atomide.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [137.167.25.139] x-exclaimer-md-config: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id w436fabK014413 > > * Eyal Reizer [180501 00:26]: > > enable mmc3 used for wlan and uart1 used for bluetooth > > configure the gpios used for wlan and bluetooth controls > > add fixed voltage regulator used for wlan power control > ... > > / { > > model = "TI AM437x SK EVM"; > > @@ -158,6 +159,22 @@ > > }; > > }; > > }; > > + > > + vmmcwl_fixed: fixedregulator-mmcwl { > > + /* > > + * WL_EN is not SDIO standard compliant. It is an out of band > > + * signal and hard to be dealt with in a standard way by the > > + * SDIO core driver. > > + * So modelling the WL_EN line as a regulator was a natural > > + * choice as the MMC core already deals with MMC supplies. > > + */ > > + compatible = "regulator-fixed"; > > + regulator-name = "vmmcwl_fixed"; > > + regulator-min-microvolt = <1800000>; > > + regulator-max-microvolt = <1800000>; > > + gpio = <&gpio4 8 GPIO_ACTIVE_HIGH>; > > + enable-active-high; > > + }; > > }; > > Interesting that it needs much longer delay here compared to the > earlier? Where do you see a delay in here? There is no startup-delay-us value used in this patch. > > BTW, I do have a patch in work to add pwrseq support for wlcore that > allows leaving out the regulator here. It still needs a bit more > work though. > > And I also have a series in work to make wlcore use runtime PM that > needs even more work, just FYI to avoid any duplicate work. > > Hmm you don't happen to have a patch series somewhere making > wlcore use the SDIO dat lien interrupt? wilink has always used out of band interrupt (using wlan_irq gpio). in-band interrupts was not supported. See section 10.5.2 in this the wl18xx hardware integration guide: http://www.ti.com/lit/ug/swru437/swru437.pdf > > I think we should use that when idle rather than the (edge) gpio > interrupt as the SDIO dat interrupt is level sensitive and wired > to the always on gpio bank for most SDIO controller instances. > On runtime PM wakeup, there's no status anywhere to been with the > GPIO edge interrupt. > I agree that it would have been better, especially for cases such as wake On wlan, but again, in-band interrupt was something that was talked about way back but it was never implemented. Best Regards, Eyal