From: Hans de Goede <hdegoede@redhat.com>
To: Mark Brown <broonie@kernel.org>
Cc: Lee Jones <lee.jones@linaro.org>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
alsa-devel@alsa-project.org,
Christian Hartmann <cornogle@googlemail.com>
Subject: Re: [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI
Date: Mon, 18 Jan 2021 14:13:50 +0100 [thread overview]
Message-ID: <5ccf48f4-45dc-3a30-3d6a-cce066f01270@redhat.com> (raw)
In-Reply-To: <20210118130227.GI4455@sirena.org.uk>
Hi,
On 1/18/21 2:02 PM, Mark Brown wrote:
> On Sun, Jan 17, 2021 at 10:22:50PM +0100, Hans de Goede wrote:
>
>> + /*
>> + * Some DSDTs wrongly declare the IRQ trigger-type as IRQF_TRIGGER_FALLING
>> + * The IRQ line will stay low when a new IRQ event happens between reading
>> + * the IRQ status flags and acknowledging them. When the IRQ line stays
>> + * low like this the IRQ will never trigger again when its type is set
>> + * to IRQF_TRIGGER_FALLING. Correct the IRQ trigger-type to fix this.
>> + */
>> + arizona->pdata.irq_flags = IRQF_TRIGGER_LOW;
>
> Are you sure that all the relevant interrupt controllers support active
> low interrupts? There were issues on some systems with missing support
> for active low interrupts (see the bodge in wm8994-irq.c to work around
> them) - it's entirely likely that there are DSDTs that are just plain
> buggy here but if someone's copying and pasting it smells like there may
> be some systems that actually need an edge triggered interrupt that
> they're getting it from.
I'm only aware of one series of devices / models which actually
use the combination of ACPI enumeration and the WM5102 codec, and that
is the Lenovo Yoga Tablet 2 series (in 8, 10 and 13 inch versions
shipping with both Windows and Android). These all use a Bay Trail
SoC which is capable of using active low interrupts.
More in general I'm not aware of any (recent-ish) x86 GPIO controllers
not being able to do active low interrupts. In theory we could hit this
code path on ARM devices using ACPI enumeration, but I don't think it
is likely we will see a combination of ARM + ACPI enumeration +
WM5102 + GPIO controller not capable of active-low interrupts.
This overriding of the flags definitely is necessary on the Lenovo
devices in question. I could add a
"if (dmi_name_in_vendors("LENOVO"))" guard around it, but that
seems unnecessary.
Regards,
Hans
>
>> +
>> + /* Wait 200 ms after jack insertion */
>> + arizona->pdata.micd_detect_debounce = 200;
>> +
>> + /* Use standard AOSP values for headset-button mappings */
>> + arizona->pdata.micd_ranges = arizona_micd_aosp_ranges;
>> + arizona->pdata.num_micd_ranges = ARRAY_SIZE(arizona_micd_aosp_ranges);
>> +
>> + return 0;
>> +}
>> +
>> +static const struct acpi_device_id arizona_acpi_match[] = {
>> + {
>> + .id = "WM510204",
>> + .driver_data = WM5102,
>> + },
>> + {
>> + .id = "WM510205",
>> + .driver_data = WM5102,
>> + },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(acpi, arizona_acpi_match);
>> +#else
>> +static int arizona_spi_acpi_probe(struct arizona *arizona)
>> +{
>> + return -ENODEV;
>> +}
>> +#endif
>> +
>> static int arizona_spi_probe(struct spi_device *spi)
>> {
>> const struct spi_device_id *id = spi_get_device_id(spi);
>> @@ -77,6 +191,12 @@ static int arizona_spi_probe(struct spi_device *spi)
>> arizona->dev = &spi->dev;
>> arizona->irq = spi->irq;
>>
>> + if (has_acpi_companion(&spi->dev)) {
>> + ret = arizona_spi_acpi_probe(arizona);
>> + if (ret)
>> + return ret;
>> + }
>> +
>> return arizona_dev_init(arizona);
>> }
>>
>> @@ -104,6 +224,7 @@ static struct spi_driver arizona_spi_driver = {
>> .name = "arizona",
>> .pm = &arizona_pm_ops,
>> .of_match_table = of_match_ptr(arizona_of_match),
>> + .acpi_match_table = ACPI_PTR(arizona_acpi_match),
>> },
>> .probe = arizona_spi_probe,
>> .remove = arizona_spi_remove,
>> --
>> 2.28.0
>>
next prev parent reply other threads:[~2021-01-18 13:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-17 21:22 [PATCH v3 0/5] MFD/ASoC: Add support for Intel Bay Trail boards with WM5102 codec Hans de Goede
2021-01-17 21:22 ` [PATCH v3 1/5] mfd: arizona: Add MODULE_SOFTDEP("pre: arizona_ldo1") Hans de Goede
2021-01-17 21:22 ` [PATCH v3 2/5] mfd: arizona: Replace arizona_of_get_type() with device_get_match_data() Hans de Goede
2021-01-18 11:51 ` Andy Shevchenko
2021-01-20 10:02 ` Charles Keepax
2021-01-17 21:22 ` [PATCH v3 3/5] mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI Hans de Goede
2021-01-18 13:02 ` Mark Brown
2021-01-18 13:13 ` Hans de Goede [this message]
2021-01-18 13:34 ` Mark Brown
2021-01-18 13:38 ` Hans de Goede
2021-01-20 19:18 ` Hans de Goede
2021-01-20 19:59 ` Andy Shevchenko
2021-01-20 21:38 ` Hans de Goede
2021-01-17 21:22 ` [PATCH v3 4/5] ASoC: Intel: Add DMI quirk table to soc_intel_is_byt_cr() Hans de Goede
2021-01-17 21:22 ` [PATCH v3 5/5] ASoC: Intel: bytcr_wm5102: Add machine driver for BYT/WM5102 Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ccf48f4-45dc-3a30-3d6a-cce066f01270@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=cornogle@googlemail.com \
--cc=lee.jones@linaro.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).