From: Gao Xiang <hsiangkao@mail.ru>
To: zhangjun <openzhangj@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Richard Weinberger <richard@nod.at>,
"Darrick J . Wong" <darrick.wong@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fix page_count in ->iomap_migrate_page()
Date: Sat, 15 Dec 2018 12:26:25 +0800 [thread overview]
Message-ID: <5cd9ea0d-4c1c-fd4d-4e29-0ee71ef272a0@mail.ru> (raw)
In-Reply-To: <1544766961-3492-1-git-send-email-openzhangj@gmail.com>
On 2018/12/14 13:56, zhangjun wrote:
> IOMAP uses PG_private a little different with buffer_head based
> filesystem.
> It uses it as marker and when set, the page counter is not incremented,
> migrate_page_move_mapping() assumes that PG_private indicates a counter
> of +1.
> so, we have to pass a extra count of -1 to migrate_page_move_mapping()
> if the flag is set.
>
> Signed-off-by: zhangjun <openzhangj@gmail.com>
> ---
I found that it fixed in
https://patchwork.kernel.org/patch/10684835/
and has been merged in
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=61c6de667263184125d5ca75e894fcad632b0dd3
It seems it has been corrected by Piotr.
Thanks,
Gao Xiang
prev parent reply other threads:[~2018-12-15 4:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 5:56 [PATCH] fix page_count in ->iomap_migrate_page() zhangjun
2018-12-14 11:25 ` Richard Weinberger
2018-12-14 12:26 ` Gao Xiang
2018-12-14 13:35 ` Richard Weinberger
2018-12-14 13:55 ` Gao Xiang
2018-12-15 10:51 ` Christoph Hellwig
2018-12-15 11:17 ` Richard Weinberger
2018-12-15 4:26 ` Gao Xiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cd9ea0d-4c1c-fd4d-4e29-0ee71ef272a0@mail.ru \
--to=hsiangkao@mail.ru \
--cc=akpm@linux-foundation.org \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openzhangj@gmail.com \
--cc=richard@nod.at \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).