From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: Juri Lelli <juri.lelli@redhat.com>, Peng Liu <iwtbavbm@gmail.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com,
peterz@infradead.org, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, valentin.schneider@arm.com,
raistlin@linux.it
Subject: Re: [PATCH v6 0/2] sched/deadline: Fix and optimize sched_dl_global_validate()
Date: Sun, 18 Oct 2020 10:27:18 +0200 [thread overview]
Message-ID: <5ce38799-f7cd-6dcb-3e10-5e4767510094@redhat.com> (raw)
In-Reply-To: <20201014133247.GC219214@localhost.localdomain>
Hi,
On 10/14/20 3:32 PM, Juri Lelli wrote:
> Hi,
>
> On 08/10/20 23:47, Peng Liu wrote:
>> When change global rt bandwidth, we check to make sure that new
>> settings could accommodate the allocated dl bandwidth.
>>
>> Under SMP, the dl_bw is on a per root domain basis, currently we check
>> and update the new settings one cpu by one cpu, but not in the unit of
>> root domain, which is either overdoing or error.
>>
>> patch 1 removed the superfluous checking and updating
>> patch 2 fixed the error validation
>>
>> For details, please see the corresponding patch.
>>
>> ----------------
>> v6 <-- v5:
>> - no functional changes, just revert visit_gen back to u64;
>>
>> v5 <-- v4:
>> - no functional changes, just split the v4 single patch to two to
>> obey the "one patch do only one thing" rule;
>> - turn root_domain::visit_gen from u64 to u32;
>> both suggested by Juri.
>> - refine changelog;
>>
>> v4 <-- v3:
>> - refine changelog;
>> - eliminate the ugly #ifdef guys with Peter's method;
>>
>> v3 <-- v2:
>> - fix build error for !CONFIG_SMP, reported by kernel test robot;
>>
>> v2 <-- v1:
>> - replace cpumask_weight(cpu_rq(cpu)->rd->span) with dl_bw_cpus(cpu),
>> suggested by Juri;
>>
>> Peng Liu (2):
>> sched/deadline: Optimize sched_dl_global_validate()
>> sched/deadline: Fix sched_dl_global_validate()
>>
>> kernel/sched/deadline.c | 44 +++++++++++++++++++++++++++--------
>> kernel/sched/sched.h | 51 ++++++++++++++++++++++-------------------
>> kernel/sched/topology.c | 1 +
>> 3 files changed, 63 insertions(+), 33 deletions(-)
>
> These look now good to me. Thanks a lot!
>
> Acked-by: Juri Lelli <juri.lelli@redhat.com>
I just found a minor thing in a comment:
"It's *monotonously* increasing."
I tried to find the usage of "monotonously increasing" for monotonic functions,
and I did not find it. The (as least most used) term is "monotonically," so the
sentence would be like "It is a monotonically increasing value." But it is just
a minor thing. Anyways:
Reviewed-by: Daniel Bristot de Oliveira <bristot@redhat.com>
Thanks!
-- Daniel
prev parent reply other threads:[~2020-10-18 8:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 15:47 [PATCH v6 0/2] sched/deadline: Fix and optimize sched_dl_global_validate() Peng Liu
2020-10-08 15:48 ` [PATCH v6 1/2] sched/deadline: Optimize sched_dl_global_validate() Peng Liu
2020-10-29 10:51 ` [tip: sched/core] " tip-bot2 for Peng Liu
2020-10-08 15:49 ` [PATCH v6 2/2] sched/deadline: Fix sched_dl_global_validate() Peng Liu
2020-10-29 10:51 ` [tip: sched/core] " tip-bot2 for Peng Liu
2020-10-14 13:32 ` [PATCH v6 0/2] sched/deadline: Fix and optimize sched_dl_global_validate() Juri Lelli
2020-10-18 8:27 ` Daniel Bristot de Oliveira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ce38799-f7cd-6dcb-3e10-5e4767510094@redhat.com \
--to=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=iwtbavbm@gmail.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=raistlin@linux.it \
--cc=rostedt@goodmis.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).