From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] crypto: x86/camellia - Replace kernel.h with the necessary inclusions
Date: Thu, 9 Jun 2022 18:50:12 +0200 [thread overview]
Message-ID: <5cf8ad88-629c-e75a-df99-e893b8af967f@wanadoo.fr> (raw)
In-Reply-To: <YqHIPE0MlZLP8C5I@gondor.apana.org.au>
Le 09/06/2022 à 12:15, Herbert Xu a écrit :
> On Sun, Jun 05, 2022 at 09:32:53AM +0200, Christophe JAILLET wrote:
>> When kernel.h is used in the headers it adds a lot into dependency hell,
>> especially when there are circular dependencies are involved.
>>
>> Replace kernel.h inclusion with the list of what is really being used.
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>> ---
>> arch/x86/crypto/camellia.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/crypto/camellia.h b/arch/x86/crypto/camellia.h
>> index 1dcea79e8f8e..547fb7e30928 100644
>> --- a/arch/x86/crypto/camellia.h
>> +++ b/arch/x86/crypto/camellia.h
>> @@ -4,7 +4,7 @@
>>
>> #include <crypto/b128ops.h>
>> #include <linux/crypto.h>
>> -#include <linux/kernel.h>
>> +#include <linux/types.h>
>>
>> #define CAMELLIA_MIN_KEY_SIZE 16
>> #define CAMELLIA_MAX_KEY_SIZE 32
>
> This is not sufficient. For example, asmlinkage isn't explicitly
> defined by any of these header files so it would be relying on an
> implicit inclusion which is prone to breakage.
Agreed, I missed that.
>
> Did you audit the entire file?
Yes, but I missed the asmlinkage.
In fact, I've sent a few "obvious" (but nothing is never obvious at the
end...) patches like that to see the interest.
I've spotted a few .h file with "easy to check" content.
Mostly #define, function declarations, a few u<something> datatypes.
Then, I made the #include simplification and compile tested the change.
If it worked, I consider that the patch looks fine.
In this particular case, I guess that the 'asmlinkage' should come from
another #include when "camellia.h" is used.
My goal was not to introduce some new hidden constraints related to the
order of the included .h. I just wanted to make them explicit (and
complete) and start to simplify things.
As said, nothing is never obvious, and I'll stay away from this kind of
changes :)
Thanks a lot for the review.
CJ
>
> Cheers,
prev parent reply other threads:[~2022-06-09 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-05 7:32 [PATCH] crypto: x86/camellia - Replace kernel.h with the necessary inclusions Christophe JAILLET
2022-06-09 10:15 ` Herbert Xu
2022-06-09 16:50 ` Christophe JAILLET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cf8ad88-629c-e75a-df99-e893b8af967f@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).