From: Chris Packham <Chris.Packham@alliedtelesis.co.nz>
To: "robh@kernel.org" <robh@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Logan Shaw <Logan.Shaw@alliedtelesis.co.nz>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"jdelvare@suse.com" <jdelvare@suse.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH 2/5] dt-bindings: hwmon: Document adt7475 bypass-attenuator property
Date: Tue, 18 Feb 2020 20:52:38 +0000 [thread overview]
Message-ID: <5d081c13807da1b64060ed56460a47d459ac3e55.camel@alliedtelesis.co.nz> (raw)
In-Reply-To: <20200218202439.GA4617@bogus>
On Tue, 2020-02-18 at 14:24 -0600, Rob Herring wrote:
> On Tue, 18 Feb 2020 12:46:54 +1300, Chris Packham wrote:
> >
> > From: Logan Shaw <logan.shaw@alliedtelesis.co.nz>
> >
> > Add documentation for the bypass-attenuator-in[0-4] property.
> >
> > Signed-off-by: Logan Shaw <logan.shaw@alliedtelesis.co.nz>
> > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > ---
> > .../devicetree/bindings/hwmon/adt7475.yaml | 13 +++++++++++++
> > 1 file changed, 13 insertions(+)
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/adt7475.yaml: patternProperties:^bypass-attenuator-in[0-4]$:maximum: False schema does not allow 1
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/adt7475.yaml: patternProperties:^bypass-attenuator-in[0-4]$:minimum: False schema does not allow 0
> Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/hwmon/adt7475.example.dts' failed
> make[1]: *** [Documentation/devicetree/bindings/hwmon/adt7475.example.dts] Error 1
> Makefile:1263: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
>
I still must be doing something wrong. I did run
make mrproper
make ARCH=arm defconfig
make ARCH=arm dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/hwmon/adt7475.yaml
which passes without error.
When I run
make mrproper
make ARCH=arm defconfig
make ARCH=arm dt_binding_check
I get errors in unrelated files
e.g.
/home/chrisp/src/linux/Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-apb1-clk.yaml: Additional properties are not allowed ('deprecated' was unexpected)
Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-apb1-clk.example.dts' failed
make[1]: *** [Documentation/devicetree/bindings/clock/allwinner,sun4i-a10-apb1-clk.example.dts] Error 1
Makefile:1262: recipe for target 'dt_binding_check' failed
My local branch is based on commit 0a679e13ea30 ("Merge branch 'for-
5.6-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup")
do I need to be running against something else?
> See https://patchwork.ozlabs.org/patch/1239694
> Please check and re-submit.
next prev parent reply other threads:[~2020-02-18 20:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-17 23:46 [PATCH 0/5] hwmon: (adt7475) attenuator bypass and pwm invert Chris Packham
2020-02-17 23:46 ` [PATCH 1/5] dt-bindings: hwmon: Document adt7475 binding Chris Packham
2020-02-17 23:46 ` [PATCH 2/5] dt-bindings: hwmon: Document adt7475 bypass-attenuator property Chris Packham
2020-02-18 20:24 ` Rob Herring
2020-02-18 20:52 ` Chris Packham [this message]
2020-02-18 23:24 ` Chris Packham
2020-02-20 20:01 ` Rob Herring
2020-02-17 23:46 ` [PATCH 3/5] dt-bindings: hwmon: Document adt7475 invert-pwm property Chris Packham
2020-02-17 23:46 ` [PATCH 4/5] hwmon: (adt7475) Add attenuator bypass support Chris Packham
2020-02-17 23:46 ` [PATCH 5/5] hwmon: (adt7475) Add support for inverting pwm output Chris Packham
2020-02-18 0:32 ` [PATCH 0/5] hwmon: (adt7475) attenuator bypass and pwm invert Guenter Roeck
2020-02-18 0:43 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d081c13807da1b64060ed56460a47d459ac3e55.camel@alliedtelesis.co.nz \
--to=chris.packham@alliedtelesis.co.nz \
--cc=Logan.Shaw@alliedtelesis.co.nz \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).