From: Stephen Boyd <swboyd@chromium.org>
To: Aniket Masule <amasule@codeaurora.org>,
andy.gross@linaro.org, david.brown@linaro.org,
mark.rutland@arm.com, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, mgottam@codeaurora.org,
vgarodia@codeaurora.org, Aniket Masule <amasule@codeaurora.org>
Subject: Re: [PATCH] arm64: dts: sdm845: Add video nodes
Date: Wed, 26 Jun 2019 14:32:40 -0700 [thread overview]
Message-ID: <5d13e479.1c69fb81.dd08b.b1e4@mx.google.com> (raw)
In-Reply-To: <1561550047-19600-1-git-send-email-amasule@codeaurora.org>
Quoting Aniket Masule (2019-06-26 04:54:07)
> This adds video nodes to sdm845 based on the examples
> in the bindings.
>
> Signed-off-by: Malathi Gottam <mgottam@codeaurora.org>
There should be a From: line with this person's name in the email if
they're the author. Otherwise this sign-off chain doesn't make sense and
it should most likely have a Co-developed-by tag instead.
> Signed-off-by: Aniket Masule <amasule@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index fcb9330..ff94cfa 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2437,6 +2437,36 @@
> <GIC_SPI 425 IRQ_TYPE_LEVEL_HIGH>;
> iommus = <&apps_smmu 0x0040 0x1>;
> };
> +
> + video-codec@aa00000 {
This needs to be sorted by address. It doesn't come after 18800000 (the
address of the node above).
> + compatible = "qcom,sdm845-venus";
> + reg = <0x0aa00000 0xff000>;
> + interrupts = <GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>;
next prev parent reply other threads:[~2019-06-26 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 11:54 [PATCH] arm64: dts: sdm845: Add video nodes Aniket Masule
2019-06-26 21:32 ` Stephen Boyd [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-20 10:08 [PATCH] arm64: dts: sdm845: add " Malathi Gottam
2018-11-21 6:35 ` Sibi Sankar
2018-11-27 7:31 ` Alexandre Courbot
2018-11-27 8:24 ` Stanimir Varbanov
2019-01-16 9:44 ` Stanimir Varbanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d13e479.1c69fb81.dd08b.b1e4@mx.google.com \
--to=swboyd@chromium.org \
--cc=amasule@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgottam@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).