From: Xingyu Chen <xingyu.chen@amlogic.com>
To: Kevin Hilman <khilman@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Neil Armstrong <narmstrong@baylibre.com>
Cc: Jianxin Pan <jianxin.pan@amlogic.com>,
Rob Herring <robh+dt@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Hanjie Lin <hanjie.lin@amlogic.com>,
<linux-amlogic@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: reset: add bindings for the Meson-A1 SoC Reset Controller
Date: Thu, 26 Sep 2019 11:40:36 +0800 [thread overview]
Message-ID: <5d2af18b-1b0a-0b35-9855-b27bbae3a71b@amlogic.com> (raw)
In-Reply-To: <7htv90rnp2.fsf@baylibre.com>
Hi, Kevin
Thanks for your review
On 2019/9/26 6:55, Kevin Hilman wrote:
> Xingyu Chen <xingyu.chen@amlogic.com> writes:
>
>> Add DT bindings for the Meson-A1 SoC Reset Controller include file,
>> and also slightly update documentation.
>>
>> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
>> Signed-off-by: Jianxin Pan <jianxin.pan@amlogic.com>
>
> The order here doesn't look right. As the sender, your sign-off should
> be last. Is Jianxin the author or are you? If Jianxin, there should be
> a "From:" line at the beginning of the changelog to indicate authorship
> that's different from the sender.
I am an author for this patchset, i will reorder Signed-off in next version.
>
>> ---
>> .../bindings/reset/amlogic,meson-reset.yaml | 1 +
>> include/dt-bindings/reset/amlogic,meson-a1-reset.h | 59 ++++++++++++++++++++++
>> 2 files changed, 60 insertions(+)
>> create mode 100644 include/dt-bindings/reset/amlogic,meson-a1-reset.h
>>
>> diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>> index 00917d8..b3f57d8 100644
>> --- a/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>> +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-reset.yaml
>> @@ -16,6 +16,7 @@ properties:
>> - amlogic,meson8b-reset # Reset Controller on Meson8b and compatible SoCs
>> - amlogic,meson-gxbb-reset # Reset Controller on GXBB and compatible SoCs
>> - amlogic,meson-axg-reset # Reset Controller on AXG and compatible SoCs
>> + - amlogic,meson-a1-reset # Reset Controller on A1 and compatible SoCs
>>
>> reg:
>> maxItems: 1
>> diff --git a/include/dt-bindings/reset/amlogic,meson-a1-reset.h b/include/dt-bindings/reset/amlogic,meson-a1-reset.h
>> new file mode 100644
>> index 00000000..8d76a47
>> --- /dev/null
>> +++ b/include/dt-bindings/reset/amlogic,meson-a1-reset.h
>> @@ -0,0 +1,59 @@
>> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>> + *
>> + * Copyright (c) 2019 Amlogic, Inc. All rights reserved.
>> + * Author: Xingyu Chen <xingyu.chen@amlogic.com>
>> + *
>> + */
>> +
>> +#ifndef _DT_BINDINGS_AMLOGIC_MESON_A1_RESET_H
>> +#define _DT_BINDINGS_AMLOGIC_MESON_A1_RESET_H
>> +
>> +/* RESET0 */
>> +#define RESET_AM2AXI_VAD 1
>
> minor nit: can you use comments/whitespace here to indicate holes?
> Please see the other amlogic files in this dir for examples.
I will fix it in next version.
>
> Kevin
>
> .
>
next prev parent reply other threads:[~2019-09-26 3:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 8:34 [PATCH v2 0/3] reset: meson: add Meson-A1 SoC support Xingyu Chen
2019-09-23 8:34 ` [PATCH v2 1/3] arm64: dts: meson: add reset controller for Meson-A1 SoC Xingyu Chen
2019-09-23 8:34 ` [PATCH v2 2/3] dt-bindings: reset: add bindings for the Meson-A1 SoC Reset Controller Xingyu Chen
2019-09-25 22:55 ` Kevin Hilman
2019-09-26 3:40 ` Xingyu Chen [this message]
2019-09-23 8:34 ` [PATCH v2 3/3] reset: add support " Xingyu Chen
2019-09-25 22:57 ` Kevin Hilman
2019-09-26 3:44 ` Xingyu Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d2af18b-1b0a-0b35-9855-b27bbae3a71b@amlogic.com \
--to=xingyu.chen@amlogic.com \
--cc=devicetree@vger.kernel.org \
--cc=hanjie.lin@amlogic.com \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).