From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbdLLBSC (ORCPT ); Mon, 11 Dec 2017 20:18:02 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:24749 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751799AbdLLBR5 (ORCPT ); Mon, 11 Dec 2017 20:17:57 -0500 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="31230669" Subject: Re: [PATCH] cgroup: limit max copied char length for cgroup file name To: Tejun Heo CC: , , References: <20171209054758.13870-1-mashimiao.fnst@cn.fujitsu.com> <20171211150551.GC2421075@devbig577.frc2.facebook.com> From: Ma Shimiao Message-ID: <5d335794-f8e1-c763-a81e-49413733b696@cn.fujitsu.com> Date: Tue, 12 Dec 2017 09:19:01 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171211150551.GC2421075@devbig577.frc2.facebook.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-MW Content-Transfer-Encoding: 7bit X-Originating-IP: [10.167.225.93] X-yoursite-MailScanner-ID: 2D78B486A76B.A77D9 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: mashimiao.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/11/2017 11:05 PM, Tejun Heo wrote: > On Sat, Dec 09, 2017 at 01:47:58PM +0800, Ma Shimiao wrote: >> the result of cgroup_file_name will be used by kernfs_remove_name, >> and then by kernfs_remove_by_name_ns(). >> If reached the max length, may have problem printed by WARN() in >> kernfs_remove_by_name_ns(). >> >> Signed-off-by: Ma Shimiao > > Can we use strscpy() instead? OK, I will update the patch > > Thanks. > -- Ma Shimiao Development Dept.I Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)