From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F179C47096 for ; Sun, 6 Jun 2021 07:40:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EFFC66139A for ; Sun, 6 Jun 2021 07:40:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230145AbhFFHmn (ORCPT ); Sun, 6 Jun 2021 03:42:43 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:44989 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbhFFHml (ORCPT ); Sun, 6 Jun 2021 03:42:41 -0400 Received: (Authenticated sender: alex@ghiti.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 89713E0002; Sun, 6 Jun 2021 07:40:44 +0000 (UTC) Subject: Re: [PATCH -fixes] riscv: Fix BUILTIN_DTB for sifive and microchip soc To: Arnd Bergmann Cc: Rob Herring , Paul Walmsley , Palmer Dabbelt , Albert Ou , DTML , linux-riscv , Linux Kernel Mailing List References: <20210604120639.1447869-1-alex@ghiti.fr> <1287f6f3-2f07-3269-9048-8f7d08eecc09@ghiti.fr> From: Alex Ghiti Message-ID: <5d3a00d1-9e45-398a-39cf-1e6e9924eb18@ghiti.fr> Date: Sun, 6 Jun 2021 09:40:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 5/06/2021 à 13:00, Arnd Bergmann a écrit : > On Sat, Jun 5, 2021 at 8:37 AM Alex Ghiti wrote: >> Le 4/06/2021 à 15:08, Arnd Bergmann a écrit : >>> On Fri, Jun 4, 2021 at 2:06 PM Alexandre Ghiti wrote: >>>> >>>> Fix BUILTIN_DTB config which resulted in a dtb that was actually not built >>>> into the Linux image: in the same manner as Canaan soc does, create an object >>>> file from the dtb file that will get linked into the Linux image. >>>> >>>> Signed-off-by: Alexandre Ghiti >>> >>> Along the same lines as the comment that Jisheng Zhang made on the fixed >>> address, building a dtb into the kernel itself fundamentally breaks generic >>> kernel images. >>> >>> I can understand using it on K210, which is extremely limited and wouldn't >>> run a generic kernel anyway, but for normal platforms like microchip and >>> sifive, it would be better to disallow CONFIG_BUILTIN_DTB in Kconfig >>> and require a non-broken boot loader. >> >> I kind of disagree because if I want to build a custom kernel for those >> platforms with a builtin dtb for some reasons (debug, development..Etc), >> I think I should be able to do so. > > How is the builtin dtb better than appended dtb, or passing the dtb to the > boot loader in that case? Ah never said it was better, just it was available so there is no reason we could not allow it :) > > Arnd > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv >