From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752408AbcIIQhb (ORCPT ); Fri, 9 Sep 2016 12:37:31 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:33216 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbcIIQh1 (ORCPT ); Fri, 9 Sep 2016 12:37:27 -0400 Subject: Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree. To: Stefan Wahren , Gerd Hoffmann References: <1473244289-20728-1-git-send-email-kraxel@redhat.com> <1473244289-20728-5-git-send-email-kraxel@redhat.com> <87650770.23554.026b1e4b-e35d-48e6-9394-7eeea0ff9add.open-xchange@email.1und1.de> <1473320687.6698.25.camel@redhat.com> <373fe61a-61d4-164e-0760-d68a0c4925dd@broadcom.com> Cc: linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Scott Branden , Ray Jui , Russell King , open list , Rob Herring , bcm-kernel-feedback-list@broadcom.com, Mark Rutland , Florian Fainelli From: Scott Branden Message-ID: <5d464384-ba0d-516f-9fde-3a65386d4834@broadcom.com> Date: Fri, 9 Sep 2016 09:37:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stefan, On 16-09-08 11:58 PM, Stefan Wahren wrote: > Hi Scott, > > Am 08.09.2016 um 21:50 schrieb Scott Branden: >> Hi Gerd/Eric >> >> On 16-09-08 12:44 AM, Gerd Hoffmann wrote: >>> On Mi, 2016-09-07 at 20:13 +0200, Stefan Wahren wrote: >>>>> Gerd Hoffmann hat am 7. September 2016 um 12:31 >>>>> geschrieben: >>>>> >>>>> >>>>> From: Eric Anholt >>>>> >>>>> This will be used for having EMMC (sdhci-bcm2835.c) drive the >>>>> wireless. >>>> >>>> sdhci-bcm2835.c has been replaced by sdhci-iproc.c >>> >>> Ah, right, I'll update the commit msg for v2. >>> >> Should we entirely remove sdhci-bcm2835.c to reduce confusion going >> forward? > > did i missed something? No - looks like I did. Everything is cleaned up in latest. > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=46cd175c9788e39a1c57698ab58f34844d216428 > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=7eb16493ecaa41ceeb448717ee2c59690cd9047f > > >> >>>> How about adding pull defines to include/dt-bindings/pinctrl/bcm2835.h? >>> >>> Already there (or do you mean something other than '#define >>> BCM2835_FSEL_*' ?) >>> >>> cheers, >>> Gerd >>> >> >> Thanks, >> Scott >