From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
matthias.bgg@gmail.com, robh+dt@kernel.org
Cc: kernel@collabora.com, dafna3@gmail.com
Subject: Re: [PATCH] arm64: dts: mt8173-elm: fix supported values for regulator-allowed-modes of da9211
Date: Fri, 4 Sep 2020 10:02:24 +0200 [thread overview]
Message-ID: <5d504bea-0934-91a9-c052-e463ad6c6d95@collabora.com> (raw)
In-Reply-To: <20200903142819.24487-1-dafna.hirschfeld@collabora.com>
Hi Dafna,
Thank you to work on this.
On 3/9/20 16:28, Dafna Hirschfeld wrote:
> According to the datasheet the allowed modes for the da9211
> regulator are sync and auto mode. This should be changed in the
> devicetree. This also fix an error message
> 'BUCKA: invalid regulator-allowed-modes element 0'
> since value 0 is invalid.
>
> Fixes: 689b937beddeb ("arm64: dts: mediatek: add mt8173 elm and hana board")
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Double checked the regulator supported modes and I can confirm that this patch
gets rid of the error message, so:
Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 1fe5dac24ba1..1a51879d5c6f 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -5,6 +5,7 @@
>
> #include <dt-bindings/input/input.h>
> #include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/regulator/dlg,da9211-regulator.h>
> #include <dt-bindings/gpio/gpio.h>
> #include "mt8173.dtsi"
>
> @@ -293,7 +294,8 @@
> regulator-max-microamp = <4400000>;
> regulator-ramp-delay = <10000>;
> regulator-always-on;
> - regulator-allowed-modes = <0 1>;
> + regulator-allowed-modes = <DA9211_BUCK_MODE_SYNC
> + DA9211_BUCK_MODE_AUTO>;
> };
>
> da9211_vgpu_reg: BUCKB {
>
next prev parent reply other threads:[~2020-09-04 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 14:28 [PATCH] arm64: dts: mt8173-elm: fix supported values for regulator-allowed-modes of da9211 Dafna Hirschfeld
2020-09-04 8:02 ` Enric Balletbo i Serra [this message]
2020-09-09 9:54 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d504bea-0934-91a9-c052-e463ad6c6d95@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=dafna3@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).