From: "Arınç ÜNAL" <arinc.unal@arinc9.com>
To: Rob Herring <robh@kernel.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Frank Wunderlich" <frank-w@public-files.de>,
"Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
"Sander Vanheule" <sander@svanheule.net>,
"René van Dorst" <opensource@vdorst.com>,
"Daniel Golle" <daniel@makrotopia.org>,
erkin.bozoglu@xeront.com,
"Sergio Paracuellos" <sergio.paracuellos@gmail.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/7] dt-bindings: net: dsa: mediatek,mt7530: remove unnecesary lines
Date: Wed, 17 Aug 2022 01:21:09 +0300 [thread overview]
Message-ID: <5d51394b-cef2-6bb2-763c-e801994f67ea@arinc9.com> (raw)
In-Reply-To: <20220816211454.GA2734299-robh@kernel.org>
On 17.08.2022 00:14, Rob Herring wrote:
> On Sat, Aug 13, 2022 at 06:44:13PM +0300, Arınç ÜNAL wrote:
>> Remove unnecessary lines as they are already included from the referred
>> dsa.yaml.
>
> You are duplicating the schema and then removing parts twice. I would
> combine patches 4 and 5 or reverse the order.
Will combine.
>
>>
>> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
>> ---
>> .../bindings/net/dsa/mediatek,mt7530.yaml | 27 -------------------
>> 1 file changed, 27 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
>> index ff51a2f6875f..a27cb4fa490f 100644
>> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
>> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml
>> @@ -162,15 +162,8 @@ allOf:
>>
>> patternProperties:
>> "^(ethernet-)?ports$":
>> - type: object
>> -
>> patternProperties:
>> "^(ethernet-)?port@[0-9]+$":
>> - type: object
>> - description: Ethernet switch ports
>> -
>> - unevaluatedProperties: false
>> -
>> properties:
>> reg:
>> description:
>> @@ -178,7 +171,6 @@ allOf:
>> 0 to 5 for user ports.
>>
>> allOf:
>> - - $ref: dsa-port.yaml#
>> - if:
>
> This 'if' schema is the only part you need actually (though you have to
> create the node structure).
Do you mean that I should take "if:" out of allOf?
>
>> properties:
>> label:
>> @@ -186,7 +178,6 @@ allOf:
>> - const: cpu
>> then:
>> required:
>> - - reg
>> - phy-mode
>>
>> - if:
>> @@ -200,15 +191,8 @@ allOf:
>>
>> patternProperties:
>> "^(ethernet-)?ports$":
>> - type: object
>> -
>> patternProperties:
>> "^(ethernet-)?port@[0-9]+$":
>> - type: object
>> - description: Ethernet switch ports
>> -
>> - unevaluatedProperties: false
>> -
>> properties:
>> reg:
>> description:
>> @@ -216,7 +200,6 @@ allOf:
>> 0 to 5 for user ports.
>>
>> allOf:
>> - - $ref: dsa-port.yaml#
>> - if:
>> properties:
>> label:
>> @@ -224,7 +207,6 @@ allOf:
>> - const: cpu
>> then:
>> required:
>> - - reg
>> - phy-mode
>>
>> - if:
>> @@ -238,15 +220,8 @@ allOf:
>>
>> patternProperties:
>> "^(ethernet-)?ports$":
>> - type: object
>> -
>> patternProperties:
>> "^(ethernet-)?port@[0-9]+$":
>> - type: object
>> - description: Ethernet switch ports
>> -
>> - unevaluatedProperties: false
>> -
>> properties:
>> reg:
>> description:
>> @@ -254,7 +229,6 @@ allOf:
>> 0 to 5 for user ports.
>>
>> allOf:
>> - - $ref: dsa-port.yaml#
>> - if:
>> properties:
>> label:
>> @@ -262,7 +236,6 @@ allOf:
>> - const: cpu
>> then:
>> required:
>> - - reg
>> - phy-mode
>>
>> unevaluatedProperties: false
>> --
>> 2.34.1
>>
>>
next prev parent reply other threads:[~2022-08-16 22:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-13 15:44 [PATCH v2 0/7] completely rework mediatek,mt7530 binding Arınç ÜNAL
2022-08-13 15:44 ` [PATCH v2 1/7] dt-bindings: net: dsa: mediatek,mt7530: make trivial changes Arınç ÜNAL
2022-08-16 20:49 ` Rob Herring
2022-08-13 15:44 ` [PATCH v2 2/7] dt-bindings: net: dsa: mediatek,mt7530: fix reset lines Arınç ÜNAL
2022-08-16 20:52 ` Rob Herring
2022-08-16 22:25 ` Arınç ÜNAL
2022-08-13 15:44 ` [PATCH v2 3/7] dt-bindings: net: dsa: mediatek,mt7530: update examples Arınç ÜNAL
2022-08-16 21:02 ` Rob Herring
2022-08-16 22:15 ` Arınç ÜNAL
2022-08-13 15:44 ` [PATCH v2 4/7] dt-bindings: net: dsa: mediatek,mt7530: define port binding per compatible Arınç ÜNAL
2022-08-19 12:43 ` Krzysztof Kozlowski
2022-08-20 7:34 ` Arınç ÜNAL
2022-08-23 10:48 ` Krzysztof Kozlowski
2022-08-13 15:44 ` [PATCH v2 5/7] dt-bindings: net: dsa: mediatek,mt7530: remove unnecesary lines Arınç ÜNAL
2022-08-16 21:14 ` Rob Herring
2022-08-16 22:21 ` Arınç ÜNAL [this message]
2022-08-13 15:44 ` [PATCH v2 6/7] dt-bindings: net: dsa: mediatek,mt7530: define phy-mode for each compatible Arınç ÜNAL
2022-08-16 21:21 ` Rob Herring
2022-08-16 22:09 ` Arınç ÜNAL
2022-08-13 15:44 ` [PATCH v2 7/7] dt-bindings: net: dsa: mediatek,mt7530: update binding description Arınç ÜNAL
2022-08-16 21:25 ` Rob Herring
2022-08-16 21:53 ` Arınç ÜNAL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d51394b-cef2-6bb2-763c-e801994f67ea@arinc9.com \
--to=arinc.unal@arinc9.com \
--cc=Landen.Chao@mediatek.com \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=erkin.bozoglu@xeront.com \
--cc=f.fainelli@gmail.com \
--cc=frank-w@public-files.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luizluca@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=opensource@vdorst.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=sander@svanheule.net \
--cc=sean.wang@mediatek.com \
--cc=sergio.paracuellos@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).