From: Stephen Boyd <swboyd@chromium.org>
To: Maulik Shah <mkshah@codeaurora.org>,
agross@kernel.org, david.brown@linaro.org,
linux-arm-msm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
bjorn.andersson@linaro.org, evgreen@chromium.org,
dianders@chromium.org, rnayak@codeaurora.org,
ilina@codeaurora.org, lsrao@codeaurora.org,
ulf.hansson@linaro.org, Maulik Shah <mkshah@codeaurora.org>
Subject: Re: [PATCH 1/4] drivers: qcom: rpmh: fix macro to accept NULL argument
Date: Wed, 14 Aug 2019 10:59:42 -0700 [thread overview]
Message-ID: <5d544c0f.1c69fb81.a78d3.1381@mx.google.com> (raw)
In-Reply-To: <20190813082442.25796-2-mkshah@codeaurora.org>
Quoting Maulik Shah (2019-08-13 01:24:39)
> Device argument matches with dev variable declared in RPMH message.
> Compiler reports error when the argument is NULL since the argument
> matches the name of the property. Rename dev argument to device to
> fix this.
>
> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> ---
Maybe this should have a Fixes tag? And the subject could be something
like "avoid shadowing local variables in macro"?
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
next prev parent reply other threads:[~2019-08-14 17:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-13 8:24 [PATCH 0/4] Add RSC power domain support Maulik Shah
2019-08-13 8:24 ` [PATCH 1/4] drivers: qcom: rpmh: fix macro to accept NULL argument Maulik Shah
2019-08-14 17:59 ` Stephen Boyd [this message]
2019-08-13 8:24 ` [PATCH 2/4] drivers: qcom: rpmh: remove rpmh_flush export Maulik Shah
2019-08-14 18:20 ` Stephen Boyd
2019-08-13 8:24 ` [PATCH 3/4] dt-bindings: soc: qcom: Add RSC power domain specifier Maulik Shah
2019-08-14 18:02 ` Stephen Boyd
2019-08-13 8:24 ` [PATCH 4/4] drivers: qcom: rpmh-rsc: Add RSC power domain support Maulik Shah
2019-08-14 18:25 ` Stephen Boyd
2019-08-23 6:49 ` Maulik Shah
2019-08-14 18:19 ` [PATCH 0/4] " Stephen Boyd
2019-08-23 6:51 ` Maulik Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d544c0f.1c69fb81.a78d3.1381@mx.google.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=dianders@chromium.org \
--cc=evgreen@chromium.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lsrao@codeaurora.org \
--cc=mkshah@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).