From: Stephen Boyd <swboyd@chromium.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Tri Vo <trong@android.com>
Subject: Re: [PATCH v3 2/2] PM / wakeup: Unexport pm_wakeup_sysfs_{add,remove}()
Date: Mon, 19 Aug 2019 11:21:54 -0700 [thread overview]
Message-ID: <5d5ae8c2.1c69fb81.25dd0.ca75@mx.google.com> (raw)
In-Reply-To: <20190819175457.231058-3-swboyd@chromium.org>
Sorry, subject should be
PM / wakeup: Unexport wakeup_source_sysfs_{add,remove}()
Quoting Stephen Boyd (2019-08-19 10:54:57)
> These functions are just used by the PM core, and that isn't modular so
> these functions don't need to be exported. Drop the exports.
>
> Fixes: 986845e747af ("PM / wakeup: Show wakeup sources stats in sysfs")
> Cc: Tri Vo <trong@android.com
Messed up the address here too. Should be
Cc: Tri Vo <trong@android.com>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
> drivers/base/power/wakeup_stats.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/base/power/wakeup_stats.c b/drivers/base/power/wakeup_stats.c
> index bc5e3945f7a8..c7734914d914 100644
> --- a/drivers/base/power/wakeup_stats.c
> +++ b/drivers/base/power/wakeup_stats.c
> @@ -182,7 +182,6 @@ int wakeup_source_sysfs_add(struct device *parent, struct wakeup_source *ws)
>
> return 0;
> }
> -EXPORT_SYMBOL_GPL(wakeup_source_sysfs_add);
>
> /**
> * pm_wakeup_source_sysfs_add - Add wakeup_source attributes to sysfs
> @@ -205,7 +204,6 @@ void wakeup_source_sysfs_remove(struct wakeup_source *ws)
> {
> device_unregister(ws->dev);
> }
> -EXPORT_SYMBOL_GPL(wakeup_source_sysfs_remove);
>
> static int __init wakeup_sources_sysfs_init(void)
> {
next prev parent reply other threads:[~2019-08-19 18:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 17:54 [PATCH v3 0/2] PM / wakeup: Fix wakeup class wrecakge in -next Stephen Boyd
2019-08-19 17:54 ` [PATCH v3 1/2] PM / wakeup: Register wakeup class kobj after device is added Stephen Boyd
2019-08-19 18:30 ` Tri Vo
2019-08-19 17:54 ` [PATCH v3 2/2] PM / wakeup: Unexport pm_wakeup_sysfs_{add,remove}() Stephen Boyd
2019-08-19 18:21 ` Stephen Boyd [this message]
2019-08-19 18:32 ` Tri Vo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5ae8c2.1c69fb81.25dd0.ca75@mx.google.com \
--to=swboyd@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=trong@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).