linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
To: Tim Gardner <tim.gardner@canonical.com>, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jslaby@suse.com>, Adam Borowski <kilobyte@angband.pl>,
	Scot Doyle <lkml14@scotdoyle.com>
Subject: Re: [PATCH linux-next] tty: Disable default console blanking interval
Date: Wed, 22 Mar 2017 10:14:45 -0400	[thread overview]
Message-ID: <5d5fe4d8-a4d4-c631-3991-072e176d0314@gmail.com> (raw)
In-Reply-To: <1490190632-10464-1-git-send-email-tim.gardner@canonical.com>

On 2017-03-22 09:50, Tim Gardner wrote:
> BugLink: http://bugs.launchpad.net/bugs/869017
>
> Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.com>
> Cc: Adam Borowski <kilobyte@angband.pl>
> Cc: Scot Doyle <lkml14@scotdoyle.com>
> ---
>
> I'm not particularly knowledgable about console issues. Is a blaknking interval
> relevant in a post CRT world ? The argument in the bug description seems
> compelling.
Burn-in still happens on at least LCD screens (not sure about anything 
else except DLP, where it doesn't happen unless it's a really crappy 
display), but on many of those it happens regardless of the contents of 
the display (I've actually got an old LCD display where the image is 
constantly dark because of having displayed so many hours of a black 
screen), but displaying a black screen instead of powering off the 
display doesn't really save any power on most modern displays and the 
fact that the screen isn't un-blanked when the kernel crashes is a 
pretty compelling argument against having it enabled by default IMO.
>
>  drivers/tty/vt/vt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
> index 5c4933b..9c99452 100644
> --- a/drivers/tty/vt/vt.c
> +++ b/drivers/tty/vt/vt.c
> @@ -181,7 +181,7 @@ int console_blanked;
>
>  static int vesa_blank_mode; /* 0:none 1:suspendV 2:suspendH 3:powerdown */
>  static int vesa_off_interval;
> -static int blankinterval = 10*60;
> +static int blankinterval;
>  core_param(consoleblank, blankinterval, int, 0444);
>
>  static DECLARE_WORK(console_work, console_callback);
>

  reply	other threads:[~2017-03-22 14:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-22 13:50 [PATCH linux-next] tty: Disable default console blanking interval Tim Gardner
2017-03-22 14:14 ` Austin S. Hemmelgarn [this message]
2017-03-22 14:54 ` Greg Kroah-Hartman
2017-03-22 15:07 ` [PATCH linux-next V2] " Tim Gardner
2017-03-23  1:32   ` Scot Doyle
2017-03-23 12:42     ` Austin S. Hemmelgarn
2017-03-24  2:27       ` Scot Doyle
2017-03-23  2:06 ` [PATCH linux-next] " Adam Borowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d5fe4d8-a4d4-c631-3991-072e176d0314@gmail.com \
    --to=ahferroin7@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=kilobyte@angband.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkml14@scotdoyle.com \
    --cc=tim.gardner@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).