From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEF1C3A59F for ; Thu, 29 Aug 2019 14:53:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8432D20644 for ; Thu, 29 Aug 2019 14:53:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cP79UUZk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728873AbfH2OxH (ORCPT ); Thu, 29 Aug 2019 10:53:07 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:40556 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728852AbfH2OxF (ORCPT ); Thu, 29 Aug 2019 10:53:05 -0400 Received: by mail-pl1-f194.google.com with SMTP id h3so1686588pls.7 for ; Thu, 29 Aug 2019 07:53:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=message-id:mime-version:content-transfer-encoding:in-reply-to :references:cc:subject:to:from:user-agent:date; bh=IVt1U8oT+FQK7aUwrMR2Tp9XbQQNNH4JQiQH6Rt7qf4=; b=cP79UUZk928DGL+GxphxoDqthoR4vlD+VEpiHJe8dJnI74dSK5hHZDn/8xoNtlwaLH IkL9g+CPoO3ERIm4twApQ3fSHH+/cFNlISlAnPCINnupwLmEXMmKVkw35ldVMfLUUOXK yToPL4+v5EmLSwhPC+E3qcL0teiSDB+eD/bXw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:mime-version :content-transfer-encoding:in-reply-to:references:cc:subject:to:from :user-agent:date; bh=IVt1U8oT+FQK7aUwrMR2Tp9XbQQNNH4JQiQH6Rt7qf4=; b=eS0JBJRoXBqPfOuG2rgB3RyStlEQE1PJRrMRUwjd76RNXh53d+h+df0MV6e0UzLdgs sFYCP+PIBVJDf+grlzgN2xuZZU49G+64hhPvRgy2zF3RoXNy28e0jNwPQuMKoxdV9jzm uBByBTzlpr+gtirvF0Q+k7SUWHFu3II2tqmJ18ElHIYoby/OQjODtWuI4fR1D0XAt+Or uuwbbHvyhTA3ZkpmC+dMXQl8fTBmTPXm5CSsrJJOSFZk/WphL7OApzU+E37xkR/vZzFg 5092M2c3eweS2R1zY93RpCYovAsn6UUDqdXDEL0IY7sD/z5nKOpKjaSnDiIqFLrn5ZW+ AneA== X-Gm-Message-State: APjAAAUNomCta6lROlBsqSGsgaulFGiw9mBHSYOYVAfR/fVi9fqfH+Fb i0qFocUAcwDVz4DTkTtjNdZOSA== X-Google-Smtp-Source: APXvYqxCLdj3EhSbQwuRFHN9HLXmn0KH0bqkF8GZwr3xBMF5lOEAwyd/+Ll4gbD0AERbHDMcrTdDfg== X-Received: by 2002:a17:902:f217:: with SMTP id gn23mr10280979plb.21.1567090384357; Thu, 29 Aug 2019 07:53:04 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id ev3sm16476457pjb.3.2019.08.29.07.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2019 07:53:03 -0700 (PDT) Message-ID: <5d67e6cf.1c69fb81.5aec9.3b71@mx.google.com> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <66ac3d3707d6296ef85bf1fa321f7f1ee0c02131.1566907161.git.amit.kucheria@linaro.org> <5d65cbe9.1c69fb81.1ceb.2374@mx.google.com> Cc: Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui , Andy Gross , Bjorn Andersson , Eduardo Valentin , linux-arm-msm , Linux Kernel Mailing List , Marc Gonzalez , Brian Masney , Linux PM list , DTML Subject: Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver To: Amit Kucheria From: Stephen Boyd User-Agent: alot/0.8.1 Date: Thu, 29 Aug 2019 07:53:02 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Amit Kucheria (2019-08-29 01:48:27) > On Wed, Aug 28, 2019 at 6:03 AM Stephen Boyd wrote: > > > > Quoting Amit Kucheria (2019-08-27 05:14:03) > > > Define two new required properties to define interrupts and > > > interrupt-names for tsens. > > > > > > Signed-off-by: Amit Kucheria > > > --- > > > Documentation/devicetree/bindings/thermal/qcom-tsens.txt | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt= b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt > > > index 673cc1831ee9d..686bede72f846 100644 > > > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.txt > > > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.txt > > > @@ -22,6 +22,8 @@ Required properties: > > > > > > - #thermal-sensor-cells : Should be 1. See ./thermal.txt for a descr= iption. > > > - #qcom,sensors: Number of sensors in tsens block > > > +- interrupts: Interrupts generated from Always-On subsystem (AOSS) > > > > Is it always one? interrupt-names makes it sound like it. > > > > > +- interrupt-names: Must be one of the following: "uplow", "critical" >=20 > Will fix to "one or more of the following" >=20 Can we get a known quantity of interrupts for a particular compatible string instead? Let's be as specific as possible. The index matters too, so please list them in the order that is desired.