From: Stephen Boyd <swboyd@chromium.org>
To: Brian Norris <briannorris@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Hung-Te Lin <hungte@chromium.org>,
Brian Norris <briannorris@chromium.org>,
stable@vger.kernel.org, Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH] firmware: google: increment VPD key_len properly
Date: Mon, 30 Sep 2019 15:26:11 -0700 [thread overview]
Message-ID: <5d928104.1c69fb81.29df9.6eef@mx.google.com> (raw)
In-Reply-To: <20190930214522.240680-1-briannorris@chromium.org>
Quoting Brian Norris (2019-09-30 14:45:22)
> Commit 4b708b7b1a2c ("firmware: google: check if size is valid when
> decoding VPD data") adds length checks, but the new vpd_decode_entry()
> function botched the logic -- it adds the key length twice, instead of
> adding the key and value lengths separately.
>
> On my local system, this means vpd.c's vpd_section_create_attribs() hits
> an error case after the first attribute it parses, since it's no longer
> looking at the correct offset. With this patch, I'm back to seeing all
> the correct attributes in /sys/firmware/vpd/...
>
> Fixes: 4b708b7b1a2c ("firmware: google: check if size is valid when decoding VPD data")
> Cc: <stable@vger.kernel.org>
> Cc: Hung-Te Lin <hungte@chromium.org>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: Stephen Boyd <swboyd@chromium.org>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
> ---
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
prev parent reply other threads:[~2019-09-30 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 21:45 [PATCH] firmware: google: increment VPD key_len properly Brian Norris
2019-09-30 22:04 ` Brian Norris
2019-09-30 22:26 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d928104.1c69fb81.29df9.6eef@mx.google.com \
--to=swboyd@chromium.org \
--cc=briannorris@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=hungte@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).