From: Jason Wang <jasowang@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
rob.miller@broadcom.com, lingshan.zhu@intel.com,
eperezma@redhat.com, lulu@redhat.com, shahafs@mellanox.com,
hanand@xilinx.com, mhabets@solarflare.com, gdawar@xilinx.com,
saugatm@xilinx.com, vmireyno@marvell.com,
zhangweining@ruijie.com.cn, eli@mellanox.com
Subject: Re: [PATCH 5/6] vdpa: introduce virtio pci driver
Date: Tue, 2 Jun 2020 15:08:39 +0800 [thread overview]
Message-ID: <5dbb0386-beeb-5bf4-d12e-fb5427486bb8@redhat.com> (raw)
In-Reply-To: <20200602010332-mutt-send-email-mst@kernel.org>
On 2020/6/2 下午1:08, Michael S. Tsirkin wrote:
> On Fri, May 29, 2020 at 04:03:02PM +0800, Jason Wang wrote:
>> +static void vp_vdpa_set_vq_ready(struct vdpa_device *vdpa,
>> + u16 qid, bool ready)
>> +{
>> + struct vp_vdpa *vp_vdpa = vdpa_to_vp(vdpa);
>> +
>> + vp_iowrite16(qid, &vp_vdpa->common->queue_select);
>> + vp_iowrite16(ready, &vp_vdpa->common->queue_enable);
>> +}
>> +
> Looks like this needs to check and just skip the write if
> ready == 0, right? Of course vdpa core then insists on calling
> vp_vdpa_get_vq_ready which will warn. Maybe just drop the
> check from core, move it to drivers which need it?
>
> ...
That may work, but it may cause inconsistent semantic for set_vq_ready
if we leave it to the driver.
>
>
>> +static const struct pci_device_id vp_vdpa_id_table[] = {
>> + { PCI_DEVICE(PCI_VENDOR_ID_REDHAT_QUMRANET, PCI_ANY_ID) },
>> + { 0 }
>> +};
> This looks like it'll create a mess with either virtio pci
> or vdpa being loaded at random. Maybe just don't specify
> any IDs for now. Down the road we could get a
> distinct vendor ID or a range of device IDs for this.
Right, will do.
Thanks
>
>> +MODULE_DEVICE_TABLE(pci, vp_vdpa_id_table);
>> +
>> +static struct pci_driver vp_vdpa_driver = {
>> + .name = "vp-vdpa",
>> + .id_table = vp_vdpa_id_table,
>> + .probe = vp_vdpa_probe,
>> + .remove = vp_vdpa_remove,
>> +};
>> +
>> +module_pci_driver(vp_vdpa_driver);
>> +
>> +MODULE_AUTHOR("Jason Wang <jasowang@redhat.com>");
>> +MODULE_DESCRIPTION("vp-vdpa");
>> +MODULE_LICENSE("GPL");
>> +MODULE_VERSION("1");
>> --
>> 2.20.1
next prev parent reply other threads:[~2020-06-02 7:09 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 8:02 [PATCH 0/6] vDPA: doorbell mapping Jason Wang
2020-05-29 8:02 ` [PATCH 1/6] vhost: allow device that does not depend on vhost worker Jason Wang
2020-06-02 5:01 ` Michael S. Tsirkin
2020-06-02 7:04 ` Jason Wang
2020-05-29 8:02 ` [PATCH 2/6] vhost: use mmgrab() instead of mmget() for non worker device Jason Wang
2020-05-29 8:03 ` [PATCH 3/6] vdpa: introduce get_vq_notification method Jason Wang
2020-05-29 8:03 ` [PATCH 4/6] vhost_vdpa: support doorbell mapping via mmap Jason Wang
2020-05-29 9:16 ` Mika Penttilä
2020-05-29 9:24 ` Jason Wang
2020-06-01 19:22 ` kbuild test robot
2020-06-02 4:56 ` Michael S. Tsirkin
2020-06-02 6:49 ` Jason Wang
2020-06-02 13:31 ` Michael S. Tsirkin
2020-06-03 4:18 ` Jason Wang
2020-06-03 6:34 ` Michael S. Tsirkin
2020-06-03 6:37 ` Jason Wang
[not found] ` <CAJPjb1JGn-+Y2EHvn1S+=uX_cjPVEUmGGo7CmAM2kTqyn4NRYQ@mail.gmail.com>
2020-06-02 2:04 ` [virtio-dev] " Jason Wang
2020-05-29 8:03 ` [PATCH 5/6] vdpa: introduce virtio pci driver Jason Wang
2020-06-02 5:08 ` Michael S. Tsirkin
2020-06-02 7:08 ` Jason Wang [this message]
2020-06-05 8:54 ` Jason Wang
2020-06-07 13:51 ` Michael S. Tsirkin
2020-06-08 3:32 ` Jason Wang
2020-06-08 6:32 ` Michael S. Tsirkin
2020-06-08 9:18 ` Jason Wang
2020-06-08 9:31 ` Michael S. Tsirkin
2020-06-08 9:43 ` Jason Wang
2020-06-08 9:45 ` Michael S. Tsirkin
2020-06-08 9:46 ` Jason Wang
2020-06-08 9:54 ` Michael S. Tsirkin
2020-06-08 10:07 ` Jason Wang
2020-06-08 13:29 ` Michael S. Tsirkin
2020-06-09 5:55 ` Jason Wang
2020-06-02 5:09 ` Michael S. Tsirkin
2020-06-02 7:12 ` Jason Wang
2020-06-04 18:50 ` Michael S. Tsirkin
2020-05-29 8:03 ` [PATCH 6/6] vdpa: vp_vdpa: report doorbell location Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dbb0386-beeb-5bf4-d12e-fb5427486bb8@redhat.com \
--to=jasowang@redhat.com \
--cc=eli@mellanox.com \
--cc=eperezma@redhat.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mhabets@solarflare.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rob.miller@broadcom.com \
--cc=saugatm@xilinx.com \
--cc=shahafs@mellanox.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=vmireyno@marvell.com \
--cc=zhangweining@ruijie.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).