From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Nishanth Menon" <nm@ti.com>,
"Angelo Compagnucci" <angelo.compagnucci@gmail.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
"Alexandru Ardelean" <ardeleanalex@gmail.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Jonathan Cameron" <jic23@kernel.org>
Cc: Florian Eckert <fe@dev.tdt.de>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family
Date: Fri, 1 Jul 2022 08:38:22 +0200 [thread overview]
Message-ID: <5dbf57e4-7573-fa63-d8f1-6ecde08a0875@linaro.org> (raw)
In-Reply-To: <20220701042919.18180-2-nm@ti.com>
On 01/07/2022 06:29, Nishanth Menon wrote:
> The adcxx4s communicates with a host processor via an SPI/Microwire Bus
> interface. The device family responds with 12bit data, of which the LSB
> bits are 0 for the lower resolution devices. I have been able to test
> adc102s051, hence adding just the missing ones in that family.
>
> Lets reuse the binding to support the family of devices with name
> ADC<bb><c>S<sss>, where
> * bb is the resolution in number of bits (8, 10, 12)
> * c is the number of channels (1, 2, 4, 8)
> * sss is the maximum conversion speed (021 for 200 kSPS, 051 for 500 kSPS
> and 101 for 1 MSPS)
>
> Complete datasheets are available at TI's website here:
> https://www.ti.com/lit/gpn/adc<bb><c>s<sss>.pdf
>
> Handling of 8, 10 and 12 bits converters are the same, the
> unavailable bits are 0 in LSB :)
>
> Inspired-by: drivers/hwmon/adcxx.c
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> Checkpatch does complain with Inspired-by: insisting it to be an email
> address.. but I was really inspired by the hwmon driver.. Don't know
> what else to say here.. we could probably drop it?
Drop it or convert to just test.
When passing checkpatch:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-01 6:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 4:29 [PATCH 0/2] iio: adc: ti-adc128s052: Add support for adc102s021 and family Nishanth Menon
2022-07-01 4:29 ` [PATCH 1/2] dt-bindings: iio: adc: ti,adc128s052: Add adc08c and adc10c family Nishanth Menon
2022-07-01 6:38 ` Krzysztof Kozlowski [this message]
2022-07-01 8:27 ` Krzysztof Kozlowski
2022-07-01 4:29 ` [PATCH 2/2] iio: adc: ti-adc128s052: Add lower resolution devices support Nishanth Menon
2022-07-01 16:40 ` Jonathan Cameron
2022-07-06 18:06 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dbf57e4-7573-fa63-d8f1-6ecde08a0875@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=angelo.compagnucci@gmail.com \
--cc=ardeleanalex@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=devicetree@vger.kernel.org \
--cc=fe@dev.tdt.de \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).